From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [RFC/PATCH 03/11] ref-filter: add option to filter only branches Date: Tue, 28 Jul 2015 15:38:34 +0200 Message-ID: References: <1438066594-5620-1-git-send-email-Karthik.188@gmail.com> <1438066594-5620-3-git-send-email-Karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, christian.couder@gmail.com, gitster@pobox.com To: Karthik Nayak X-From: git-owner@vger.kernel.org Tue Jul 28 15:38:47 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZK55g-0005Am-AD for gcvg-git-2@plane.gmane.org; Tue, 28 Jul 2015 15:38:44 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbbG1Nik (ORCPT ); Tue, 28 Jul 2015 09:38:40 -0400 Received: from mx1.imag.fr ([129.88.30.5]:60939 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbG1Nij (ORCPT ); Tue, 28 Jul 2015 09:38:39 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t6SDcXn6009489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 28 Jul 2015 15:38:33 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t6SDcYvB032616; Tue, 28 Jul 2015 15:38:34 +0200 In-Reply-To: <1438066594-5620-3-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Tue, 28 Jul 2015 12:26:28 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Tue, 28 Jul 2015 15:38:33 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t6SDcXn6009489 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1438695514.19266@FrvOA87asKrzVhdKAWfs0A Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > +static int filter_branch_kind(struct ref_filter *filter, const char *refname) > +{ > + int kind, i; > + > + static struct { > + int kind; > + const char *prefix; > + } ref_kind[] = { > + { REF_LOCAL_BRANCH, "refs/heads/" }, > + { REF_REMOTE_BRANCH, "refs/remotes/" }, > + }; Nit: I would swap the order of fields, to make it a bit clearer that this is a kind of dictionary key -> value (I think it's more common to write it in this order than value <- key). -- Matthieu Moy http://www-verimag.imag.fr/~moy/