git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Benoît Person" <benoit.person@ensimag.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement
Date: Fri, 28 Jun 2013 00:21:26 +0200	[thread overview]
Message-ID: <vpqhagj9oux.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAETqRCjZdv-_V3jmhjxZj+_XU7AKRvMZ3ojo7=yW3m846F4E1w@mail.gmail.com> (=?iso-8859-1?Q?=22Beno=EEt?= Person"'s message of "Thu, 27 Jun 2013 20:53:16 +0200")

Benoît Person <benoit.person@ensimag.fr> writes:

>> Two possible alternatives:
>>
>>  - Is there a reason you would not want to "install" whatever Perl
>>    modules you want to "use" via GITPERLLIB mechanism to
>>    ../../perl/blib/lib?
> If we are making modifications to Git/Mediawiki.pm or even git-mw.perl
> / git-remote-mediawiki.perl, installing them without proper testing
> beforehand seems wrong.

That's not "installing" (i.e. not "make install"), just a copy within
the source tree. Same as what's done in Git's toplevel.

> But it was weird to work on that in this serie which initial goal was
> to add a preview tool for git-remote-mediawiki and ended up adding a
> new perl package, a new 'git mw' command which handles subcommands,
> ...

That's life ;-). Refactoring as you add new features is really important
(remember your first attempt with a huge copy/paste ... nice for
prototyping, but not acceptable in the long run).

> In the end, this patch could be removed from the serie since it is
> self-contained : it is not used by 3/5, 4/5, and 5/5.

Well, it's the one that makes them usable without "make install"-ing, so
I think it should remain part of the series.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-06-27 22:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 17:37 [PATCH v6 0/5] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-27 17:37 ` [PATCH v6 1/5] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-06-27 17:37 ` [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement benoit.person
2013-06-27 17:57   ` Junio C Hamano
2013-06-27 18:47     ` Matthieu Moy
2013-06-27 18:53     ` Benoît Person
2013-06-27 22:21       ` Matthieu Moy [this message]
2013-06-29 11:09         ` Benoît Person
2013-07-01  7:46           ` Matthieu Moy
2013-06-27 17:37 ` [PATCH v6 3/5] git-remote-mediawiki: factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-06-27 17:37 ` [PATCH v6 4/5] git-remote-mediawiki: Adding git-mw command benoit.person
2013-06-27 17:37 ` [PATCH v6 5/5] git-remote-mediawiki: Add preview subcommand into git mw benoit.person

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqhagj9oux.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=benoit.person@ensimag.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).