git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, roucherj <roucherj@telesun.imag.fr>,
	git@vger.kernel.org, kim-thuat.nguyen@ensimag.fr,
	pavel.volek@ensimag.fr, javier.roucher-iglesias@ensimag.fr
Subject: Re: credential-helpers + remote-helper, starting  point?
Date: Fri, 25 May 2012 11:15:10 +0200	[thread overview]
Message-ID: <vpqfwaotye9.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vtxz5ut84.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 24 May 2012 15:09:15 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Jeff King <peff@peff.net> writes:
>
>> On Thu, May 24, 2012 at 09:20:08PM +0200, Matthieu Moy wrote:
>>
>> +This document describes two interfaces: the C API that the credential
>> +subsystem provides to the rest of git, and the protocol that git uses to
>> +communicate with system-specific "credential helpers". If you are
>> +writing git code that wants to look up or prompt for credentials, see
>
> Don't you "prompt" yourself?  The above sounds as if you are delegating
> both looking up and prompting to the helper.

It seems I misunderstood how it worked, indeed. I thought the prompting
could also be done by the helper (it seems sensible if you're going to
use your desktop's keyring to also allow the desktop's GUI for prompting
for example).

Looking closely at the code, credential_fill either delegates fetching
data to the remote helper, or does the prompting. IOW, the prompting is
done behind the C API anyway, but most likely from credential.c than
from the external helper. Is that understanding correct?

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2012-05-25  9:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 15:14 credential-helpers + remote-helper, starting point? roucherj
2012-05-24 18:21 ` Jeff King
2012-05-24 19:20   ` Matthieu Moy
2012-05-24 20:01     ` Jeff King
2012-05-24 20:23       ` Matthieu Moy
2012-05-24 22:09       ` Junio C Hamano
2012-05-25  9:15         ` Matthieu Moy [this message]
2012-05-25 13:28   ` roucherj
2012-05-25 20:35     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqfwaotye9.fsf@bauges.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=javier.roucher-iglesias@ensimag.fr \
    --cc=kim-thuat.nguyen@ensimag.fr \
    --cc=pavel.volek@ensimag.fr \
    --cc=peff@peff.net \
    --cc=roucherj@telesun.imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).