From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable Date: Wed, 03 Jul 2013 12:57:18 +0200 Message-ID: References: <1372804789-12732-1-git-send-email-benoit.person@ensimag.fr> <1372804789-12732-3-git-send-email-benoit.person@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, Celestin Matte , Junio C Hamano To: benoit.person@ensimag.fr X-From: git-owner@vger.kernel.org Wed Jul 03 12:57:31 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UuKkc-0006zC-Nf for gcvg-git-2@plane.gmane.org; Wed, 03 Jul 2013 12:57:31 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754270Ab3GCK50 (ORCPT ); Wed, 3 Jul 2013 06:57:26 -0400 Received: from mx1.imag.fr ([129.88.30.5]:50387 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795Ab3GCK50 (ORCPT ); Wed, 3 Jul 2013 06:57:26 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r63AvHqO021684 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 3 Jul 2013 12:57:17 +0200 Received: from anie.imag.fr ([129.88.7.32]) by mail-veri.imag.fr with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UuKkQ-0002hV-F5; Wed, 03 Jul 2013 12:57:18 +0200 In-Reply-To: <1372804789-12732-3-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Wed, 3 Jul 2013 00:39:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 03 Jul 2013 12:57:18 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r63AvHqO021684 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1373453840.94078@fCOLrfJHvmR7o6Gcmk82Ug Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: benoit.person@ensimag.fr writes: > diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh > index 53a8dd0..dbebe49 100644 > --- a/wrap-for-bin.sh > +++ b/wrap-for-bin.sh > @@ -14,7 +14,7 @@ else > GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' > export GIT_TEMPLATE_DIR > fi > -GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib' > +GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib:'"$GITPERLLIB" Then you need to do something like this to prevent broken $GITPERLLIB in user's configuration from interfering with the testsuite: --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -92,6 +92,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' print join("\n", @vars); ') unset XDG_CONFIG_HOME +unset GITPERLLIB GIT_AUTHOR_EMAIL=author@example.com GIT_AUTHOR_NAME='A U Thor' GIT_COMMITTER_EMAIL=committer@example.com -- Matthieu Moy http://www-verimag.imag.fr/~moy/