From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: "Väinö Järvelä" <v@pp.inet.fi>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] Add "--only-untracked" flag to status commands.
Date: Thu, 23 Aug 2007 22:50:11 +0200 [thread overview]
Message-ID: <vpqabsikmbg.fsf@bauges.imag.fr> (raw)
In-Reply-To: <11878991123605-git-send-email-v@pp.inet.fi> ("Väinö Järvelä"'s message of "Thu\, 23 Aug 2007 22\:58\:31 +0300")
Väinö Järvelä <v@pp.inet.fi> writes:
> Subject: Re: [PATCH 1/2] Add "--only-untracked" flag to status commands.
^^
I suppose you meant --only-tracked.
> static const char runstatus_usage[] =
> -"git-runstatus [--color|--nocolor] [--amend] [--verbose] [--untracked]";
> +"git-runstatus [--color|--nocolor] [--amend] [--verbose]
> [--untracked]" "[--only-tracked]";
^^^
The compiler will concatenate the strings, but won't add a space. That
results in "... [--untracked][--only-tracked]".
Otherwise, the patch sounds fine to me. Not /terribly/ usefull, but
why not.
--
Matthieu
next prev parent reply other threads:[~2007-08-23 20:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4fcfda4a654b003f3ae3dc8d56424b5f59f48093.1187897406.git.v@pp.inet.fi>
2007-08-23 19:58 ` [PATCH 1/2] Add "--only-untracked" flag to status commands Väinö Järvelä
2007-08-23 20:50 ` Matthieu Moy [this message]
2007-08-24 6:28 ` Väinö Järvelä
[not found] ` <4ec861b086e2d349289f956ea0fe9f4d0559a568.1187897406.git.v@pp.inet.fi>
2007-08-23 19:58 ` [PATCH 2/2] Documented "--only-untracked" flag Väinö Järvelä
2007-08-23 20:32 ` [PATCH 1/2] Add "--only-untracked" flag to status commands Alex Riesen
2007-08-24 6:35 ` Väinö Järvelä
2007-08-24 7:40 ` Jakub Narebski
2007-08-27 13:18 ` Andreas Ericsson
2007-08-24 7:46 ` Junio C Hamano
2007-08-24 9:31 ` Väinö Järvelä
2007-08-24 9:55 ` Johannes Schindelin
2007-08-24 10:52 ` Väinö Järvelä
2007-08-25 14:39 ` Johannes Schindelin
2007-08-24 11:40 ` Matthieu Moy
2007-08-24 22:47 ` Jakub Narebski
2007-08-24 23:06 ` Junio C Hamano
2007-08-25 6:16 ` Väinö Järvelä
2007-08-25 14:42 ` Johannes Schindelin
2007-08-24 22:33 ` Alex Riesen
2007-08-25 5:37 ` Väinö Järvelä
2007-08-25 6:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqabsikmbg.fsf@bauges.imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=v@pp.inet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).