From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH 01/18] Follow perlcritic's recommendations - level 5 and 4 Date: Fri, 07 Jun 2013 10:10:24 +0200 Message-ID: References: <1370547263-13558-1-git-send-email-celestin.matte@ensimag.fr> <1370547263-13558-2-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, benoit.person@ensimag.fr To: =?iso-8859-1?Q?C=E9lestin?= Matte X-From: git-owner@vger.kernel.org Fri Jun 07 10:10:48 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ukrl0-0006XX-Sz for gcvg-git-2@plane.gmane.org; Fri, 07 Jun 2013 10:10:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532Ab3FGIKi convert rfc822-to-quoted-printable (ORCPT ); Fri, 7 Jun 2013 04:10:38 -0400 Received: from mx1.imag.fr ([129.88.30.5]:56856 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043Ab3FGIKd (ORCPT ); Fri, 7 Jun 2013 04:10:33 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r578AO8I028888 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 7 Jun 2013 10:10:24 +0200 Received: from anie.imag.fr ([129.88.7.32]) by mail-veri.imag.fr with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Ukrkf-0005Ar-37; Fri, 07 Jun 2013 10:10:25 +0200 In-Reply-To: <1370547263-13558-2-git-send-email-celestin.matte@ensimag.fr> (=?iso-8859-1?Q?=22C=E9lestin?= Matte"'s message of "Thu, 6 Jun 2013 21:34:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Fri, 07 Jun 2013 10:10:25 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r578AO8I028888 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1371197428.06534@oxUETNRLljpZBAo3zH/WQQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: C=E9lestin Matte writes: > Subject: [PATCH 01/18] Follow perlcritic's recommendations - level 5 = and 4 It would be better to prefix commit messages with "git-remote-mediawiki= : ". > Fix warnings from perlcritic's level 5 and 4. It would be cool to have a "make perlcritic" target in the Makefile so that future developers can easily re-run it and avoid repeating the sam= e mistakes. As much as possible, "make perlcritic" should produce no output at the end of your patch series (either the warnings should be fixed, or they should be disabled). --=20 Matthieu Moy http://www-verimag.imag.fr/~moy/