From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern Date: Thu, 09 Jul 2015 15:32:45 +0200 Message-ID: References: <1436437671-25600-1-git-send-email-karthik.188@gmail.com> <1436437671-25600-5-git-send-email-karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, christian.couder@gmail.com To: Karthik Nayak X-From: git-owner@vger.kernel.org Thu Jul 09 15:32:59 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZDBwe-0004QA-I3 for gcvg-git-2@plane.gmane.org; Thu, 09 Jul 2015 15:32:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbbGINcw (ORCPT ); Thu, 9 Jul 2015 09:32:52 -0400 Received: from mx1.imag.fr ([129.88.30.5]:53495 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbbGINcv (ORCPT ); Thu, 9 Jul 2015 09:32:51 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t69DWiTH006919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 Jul 2015 15:32:44 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t69DWjB9018294; Thu, 9 Jul 2015 15:32:45 +0200 In-Reply-To: <1436437671-25600-5-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 9 Jul 2015 15:57:46 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Thu, 09 Jul 2015 15:32:44 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t69DWiTH006919 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1437053568.17685@rXy5uIDZ3qtxBJpoECyxVQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > Since 'ref-filter' only has an option to match path names > add an option for regular pattern matching. Here also, a hint on why this is needed would be welcome. > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -956,6 +956,20 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit) > > /* > * Return 1 if the refname matches one of the patterns, otherwise 0. > + * A pattern can be a literal prefix (e.g. a refname "refs/heads/master" > + * matches a pattern "refs/heads/m") or a wildcard (e.g. the same ref > + * matches "refs/heads/m*",too). Missing space after , (same in the hunk context below) -- Matthieu Moy http://www-verimag.imag.fr/~moy/