From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v1] travis-ci: build documentation
Date: Mon, 25 Apr 2016 11:37:26 +0200 [thread overview]
Message-ID: <vpq8u02yqp5.fsf@anie.imag.fr> (raw)
In-Reply-To: <E752A0BF-92D9-4BCF-ADD2-94F8E7BD66F2@gmail.com> (Lars Schneider's message of "Mon, 25 Apr 2016 10:17:25 +0200")
Lars Schneider <larsxschneider@gmail.com> writes:
> On 22 Apr 2016, at 11:07, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
>
>> The ; or the newline is not needed either.
> Unfortunately it seems to be required. Travis CI generates a shell script
> out of the yml file and I think they don't respect newlines or something...
OK.
>>> + then
>>> + echo ""
>>> + echo "------------------------------------------------------------------------" &&
>>
>> I usualy avoid "echo <something-starting-with-dash>" as I'm not sure how
>> portable it is across variants of "echo". Maybe this one is portable
>> enough, I don't know. Perhaps printf, or cat << EOF ...?
> I am curious. Do you have an example on what platform echo "-something"
> could go wrong? I wasn't aware of such an issue.
echo can, but doesn't have to implement non-POSIX options. For example,
$ dash -c 'echo -e foo'
-e foo
$ bash -c 'echo -e foo'
foo
This is a good reason to avoid
echo "$string"
if $string is a user-supplied string.
I don't know if any shell have issue with --------, but I wouldn't be
surprised if some implementation complained with "invalid option
---------".
But it is also likely that I'm the one being paranoid and your code is
fine ;-).
>> test -s Documentation/git.html &&
>> test -s Documentation/git.1
> Great idea. Added to v2! The && is not necessary as Travis runs this script with "set -e".
Maybe I'm doing too much Python, but "explicit is better than
implicit" ;-). I'd keep the && in case someone ever moves the code to a
script that doesn't have -e, but I'm really nit-picking here ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-04-25 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 8:34 [PATCH v1] travis-ci: build documentation larsxschneider
2016-04-22 9:07 ` Matthieu Moy
2016-04-22 18:14 ` Junio C Hamano
2016-04-25 8:33 ` Lars Schneider
2016-04-25 16:56 ` Junio C Hamano
2016-04-25 19:03 ` Junio C Hamano
2016-04-25 19:32 ` Matthieu Moy
2016-04-25 19:46 ` Junio C Hamano
2016-04-25 9:26 ` Matthieu Moy
2016-04-25 8:17 ` Lars Schneider
2016-04-25 9:37 ` Matthieu Moy [this message]
2016-04-22 10:45 ` stefan.naewe
2016-04-25 8:20 ` Lars Schneider
2016-04-23 3:39 ` Jeff King
2016-04-25 8:35 ` Lars Schneider
2016-04-25 17:07 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq8u02yqp5.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).