From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PUB]What's cooking in git.git (Aug 2015, #05; Fri, 28)
Date: Mon, 31 Aug 2015 19:16:37 +0200 [thread overview]
Message-ID: <vpq4mjf74zu.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqqmvx7xz45.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 31 Aug 2015 08:21:30 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> * ad/bisect-terms (2015-08-03) 4 commits
>>> - bisect: allow setting any user-specified in 'git bisect start'
>>> - bisect: add 'git bisect terms' to view the current terms
>>> - bisect: add the terms old/new
>>> - bisect: sanity check on terms
>>>
>>> The use of 'good/bad' in "git bisect" made it confusing to use when
>>> hunting for a state change that is not a regression (e.g. bugfix).
>>> The command learned 'old/new' and then allows the end user to
>>> say e.g. "bisect start --term-old=fast --term=new=slow" to find a
>>> performance regression.
>>>
>>> Michael's idea to make 'good/bad' more intelligent does have
>>> certain attractiveness ($gname/272867), and makes some of the work
>>> on this topic a moot point.
>>>
>>> Will hold.
>>
>> This topic has been there for a while and unless I missed a discussion,
>> nothing happened. While I agree that Michael's idea is good and makes
>> this series less useful, I think this topic also makes sense.
>>
>> I'd be in favor of merging it.
>
> "Nothing happened" is never a good enough reason to argue for
> merging new stuff, but now you are starting a discussion here, let's
> see where it takes us to. I am neutral myself at this moment.
Right, but my feeling after the previous discussion was that people were
mostly in favor of merging the changes (i.e. allowing user-defined
bisect terms), but we wanted to make sure we didn't get any objection on
second thought, hence it was a good thing to have an extended cooking
period.
To add arguments in favor of merging: even if we get the "auto swap
good/bad", having user-defined terms can still help for situations where
the change between states does not correspond to a situation where one
state is 'good' and one is 'bad' eg. --term-old=red --term-new=blue.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-08-31 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 21:11 What's cooking in git.git (Aug 2015, #05; Fri, 28) Junio C Hamano
2015-08-28 21:26 ` Eric Sunshine
2015-08-29 4:15 ` Christian Couder
2015-08-31 14:36 ` Junio C Hamano
2015-08-31 18:30 ` David Turner
2015-08-31 20:06 ` Junio C Hamano
2015-08-31 20:12 ` Christian Couder
2015-08-31 7:36 ` [PUB]What's " Matthieu Moy
2015-08-31 7:48 ` Christian Couder
2015-08-31 15:21 ` Junio C Hamano
2015-08-31 17:16 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq4mjf74zu.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).