From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Johan Hovold <johan@kernel.org>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Kevin Daudt <me@ikke.info>, Junio C Hamano <gitster@pobox.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: body-CC-comment regression
Date: Fri, 17 Feb 2017 17:58:11 +0100 [thread overview]
Message-ID: <vpq4lzs7o0s.fsf@anie.imag.fr> (raw)
In-Reply-To: <20170217164241.GE2625@localhost> (Johan Hovold's message of "Fri, 17 Feb 2017 17:42:41 +0100")
> On Fri, Feb 17, 2017 at 02:16:42PM +0100, Matthieu Moy wrote:
>> Johan Hovold <johan@kernel.org> writes:
>
>> The "multiple emails per Cc: field" has been there for a while already
>> (b1c8a11c8024 released in 2.6.0, sept 2015), some users may have got
>> used to it. What you are proposing breaks their flow.
>
> Note that that commit never mentions multiple addresses in either
> headers or body-tags -- it's all about being able to specify multiple
> entries on the command line.
Indeed. I'm not the author of the patch, but I was supervising the
students who wrote it and "multiple addresses in Cc:" was not the goal,
but a (IMHO positive) side effect we discovered after the fact.
If I had a time machine, I'd probably go back then and forbid multiple
addresses there, but ...
> There does not seem to be single commit in the kernel where multiple
> address are specified in a CC tag since after git-send-email started
> allowing it, but there are ten commits before (to my surprise), and that
> should be contrasted with at least 4178 commits with trailing comments
> including a # sign.
Hey, there's a life outside the kernel ;-).
>> 1) Stop calling Mail::Address even if available.[...]
>
> Right, that sounds like the right thing to do regardless.
>
>> 2) Modify our in-house parser to discard garbage after the >. [...]
>
> Sounds perfectly fine to me, and seems to work too after quick test.
OK, sounds like the way to go.
Do you want to work on a patch? If not, I should be able to do that
myself. The code changes are straightforward, but we probably want a
proper test for that.
> addresses in a Cc-tag in that it breaks --suppress-cc=self, but I guess
> that can be fixed separately.
OK. If it's unrelated enough, please start a separate thread to explain
the problem (and/or write a patch ;-) ).
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2017-02-17 16:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 17:49 body-CC-comment regression Johan Hovold
2017-02-16 17:59 ` Junio C Hamano
2017-02-16 18:14 ` Johan Hovold
2017-02-16 18:16 ` Matthieu Moy
2017-02-17 11:06 ` Johan Hovold
2017-02-17 13:16 ` Matthieu Moy
2017-02-17 16:42 ` Johan Hovold
2017-02-17 16:58 ` Matthieu Moy [this message]
2017-02-17 17:30 ` Johan Hovold
2017-02-17 18:18 ` Junio C Hamano
2017-02-17 18:23 ` Johan Hovold
2017-02-17 18:28 ` Junio C Hamano
2017-02-17 18:44 ` Matthieu Moy
2017-02-17 20:05 ` Junio C Hamano
2017-02-17 20:20 ` Matthieu Moy
2017-02-17 22:22 ` Junio C Hamano
2017-02-17 23:04 ` Junio C Hamano
2017-02-20 11:44 ` [PATCH v2] send-email: only allow one address per body tag Johan Hovold
2017-02-20 12:10 ` Matthieu Moy
2017-02-23 18:53 ` Junio C Hamano
2017-02-26 20:45 ` Matthieu Moy
2017-02-17 17:38 ` body-CC-comment regression Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq4lzs7o0s.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).