From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Wesley J. Landaker" <wjl@icecavern.net>
Cc: git@vger.kernel.org,
Sergio Callegari <sergio.callegari@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: git fsck not identifying corrupted packs
Date: Tue, 20 Oct 2009 08:24:13 +0200 [thread overview]
Message-ID: <vpq3a5etwfm.fsf@bauges.imag.fr> (raw)
In-Reply-To: <200910191307.56989.wjl@icecavern.net> (Wesley J. Landaker's message of "Mon\, 19 Oct 2009 13\:07\:56 -0600")
"Wesley J. Landaker" <wjl@icecavern.net> writes:
> Until I read this thread, I didn't realize you needed --full to check
> objects in packs.
Same here.
> - OPT_BOOLEAN(0, "full", &check_full, "also consider alternate objects"),
> + OPT_BOOLEAN(0, "full", &check_full, "also consider packs and alternate objects"),
IMHO, something like this should be applied to "maint", this is kind
of a serious bug indeed. Just check the "alternate" thing, according
to Junio:
Junio C Hamano <gitster@pobox.com> writes:
> Side note. I think the help description of --full option is wrong (or
> at least stale). We always look at alternate object store these days
> since e15ef66 (fsck: check loose objects from alternate object stores
> by default, 2009-01-30). It probably should read "check packed
> objects fully" or something.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2009-10-20 6:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 7:56 git fsck not identifying corrupted packs Sergio Callegari
2009-10-19 9:11 ` Johannes Sixt
2009-10-19 10:04 ` Johannes Schindelin
2009-10-19 19:03 ` Junio C Hamano
2009-10-19 19:27 ` Wesley J. Landaker
2009-10-20 15:41 ` Robin Rosenberg
2009-10-20 16:20 ` Wesley J. Landaker
2009-10-20 6:26 ` Matthieu Moy
2009-10-20 6:45 ` Junio C Hamano
2009-10-20 9:25 ` Alex Riesen
2009-10-20 10:22 ` Johannes Schindelin
2009-10-20 11:56 ` Matthieu Moy
2009-10-20 18:46 ` [RFC/PATCH] fsck: default to "git fsck --full" Junio C Hamano
2009-10-20 19:00 ` Nicolas Pitre
2009-10-20 19:11 ` Junio C Hamano
2009-10-20 18:39 ` git fsck not identifying corrupted packs Nicolas Pitre
2009-10-20 20:49 ` Alex Riesen
2009-10-19 10:56 ` Sergio Callegari
2009-10-19 19:07 ` Wesley J. Landaker
2009-10-20 6:24 ` Matthieu Moy [this message]
2009-10-19 18:36 ` Gabor Gombas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq3a5etwfm.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=sergio.callegari@gmail.com \
--cc=wjl@icecavern.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).