From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: clement.poulain@ensimag.imag.fr, <spearce@spearce.org>,
<git@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] git-gui blame: use textconv
Date: Wed, 16 Jun 2010 09:50:56 +0200 [thread overview]
Message-ID: <vpq39wnbelb.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vr5k9a5f5.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 14 Jun 2010 10\:29\:50 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> (we might need to devise a transition strategy so
> that people who want to use slightly newer git-gui with older git won't
> get hurt).
I don't think these users would really get hurt: they could still use
git gui blame on text files, and they would anyway not have obtained
anything sensible from "git gui blame binary-file". In the very
unlikely case where a user has a textconv filter activated for a file
which can be viewed as text too, there's a checkbox to disable
textconv provided by Clément's patch.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-06-16 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 17:02 [PATCH v3 0/4] git-gui blame: use textconv Clément Poulain
2010-06-09 17:02 ` [PATCH v3 1/4] sha1_name: add get_sha1_with_context() Clément Poulain
2010-06-09 17:02 ` [PATCH v3 2/4] textconv: support for cat_file Clément Poulain
2010-06-09 17:02 ` [PATCH v3 3/4] git gui: use textconv filter for diff and blame Clément Poulain
2010-06-09 17:02 ` [PATCH v3 4/4] t/t8007: test textconv support for cat-file Clément Poulain
2010-06-14 17:18 ` [PATCH v3 0/4] git-gui blame: use textconv Clément Poulain
2010-06-14 17:29 ` Junio C Hamano
2010-06-16 7:50 ` Matthieu Moy [this message]
2010-06-15 15:50 ` [PATCH v3 2/4] textconv: support for cat_file Clément Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq39wnbelb.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).