Re: [PATCH v2 2/2] Makefile: use compat regex on Solaris

[Brandon Casey <casey@nrlssc.navy.mil>]

Jeff King wrote:
> The system regex is either slow or buggy for complex
> patterns, like the built-in xfuncname pattern for java
> files.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Rebased to today's master to resolve textual conflicts.
> 
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 0cb21da..3bd0c08 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -725,6 +725,7 @@ ifeq ($(uname_S),SunOS)
>  	NO_MEMMEM = YesPlease
>  	NO_MKDTEMP = YesPlease
>  	NO_MKSTEMPS = YesPlease
> +	NO_REGEX = YesPlease
>  	ifeq ($(uname_R),5.7)
>  		NEEDS_RESOLV = YesPlease
>  		NO_IPV6 = YesPlease


You need to add -DHAVE_ALLOCA_H to the BASIC_CFLAGS statement in
the SunOS section of the Makefile so that alloca.h will be included
in compat/regex/regex.c.  This is necessary for the SUNWspro compiler.
It takes me a long time to compile, so I haven't checked yet whether
this causes any problems for the GNU compiler.

-brandon