Re: [PATCH v5 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Abhradeep,

On Mon, 8 Aug 2022, Abhradeep Chakraborty wrote:

> On Mon, Aug 8, 2022 at 6:36 PM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Tue, 2 Aug 2022, Abhradeep Chakraborty wrote:
> >
> > > On Tue, Aug 2, 2022 at 9:05 PM Johannes Schindelin
> > > <Johannes.Schindelin@gmx.de> wrote:
> > >
> > > > Since you are very familiar with the details of bitmaps now, I would
> > > > like to encourage you to work on some kind of validator/inspector,
> > > > e.g. something along the lines of a `test-tool midx-bitmap dump` (and
> > > > later `... verify`) that would help future you (and future me)
> > > > investigate similar breakages. Ideally, that tool will not only parse
> > > > the `.bitmap` file but immediately print out everything in a
> > > > human-readable form.
> >
> > Have you made progress on this? I am interested mostly because I am trying
> > very hard to maintain passing CI runs of Git for Windows' `shears/seen`
> > branch (which essentially tries to rebase all of Git for Windows' patches
> > on top of `seen`), and this failure is consistently causing said CI runs
> > to fail for a while already.
>
> Hey Dscho, I am trying hard to solve the issue but unfortunately I
> haven't found the key yet.

The tool I proposed could potentially help, in particular with
distributing the burden of the investigation on more shoulders than just
yours.

> I investigated the bitmap code-base and used debug lines but didn't
> find a way to fix it.

Have you investigated whether the `.bitmap` file was produced for the
latest set of pack files? It should be relatively quick to investigate
that, and if it turns out not to be the case, the fix should be quick,
too.

Thanks,
Dscho