git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: js/bisect-in-c (was: What's cooking in git.git (Oct 2022, #09; Mon, 31))
Date: Thu, 10 Nov 2022 14:32:15 +0100 (CET)	[thread overview]
Message-ID: <s024qpqn-0roo-3rr2-nr4p-74p9296r6p02@tzk.qr> (raw)
In-Reply-To: <221102.86cza52rt0.gmgdl@evledraar.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2567 bytes --]

Hi Ævar,

On Wed, 2 Nov 2022, Ævar Arnfjörð Bjarmason wrote:

> On Mon, Oct 31 2022, Taylor Blau wrote:
>
> > What's cooking in git.git (Oct 2022, #09; Mon, 31)
> > --------------------------------------------------
> >
> > * js/bisect-in-c (2022-08-30) 17 commits
> >  . bisect: no longer try to clean up left-over `.git/head-name` files
> >  . bisect: remove Cogito-related code
> >  . Turn `git bisect` into a full built-in
> >  . bisect: move even the command-line parsing to `bisect--helper`
> >  . bisect--helper: make `state` optional
> >  . bisect--helper: calling `bisect_state()` without an argument is a bug
> >  . bisect: avoid double-quoting when printing the failed command
> >  . bisect run: fix the error message
> >  . bisect: verify that a bogus option won't try to start a bisection
> >  . bisect--helper: migrate to OPT_SUBCOMMAND()
> >  . bisect--helper: make the order consistently `argc, argv`
> >  . bisect--helper: make `terms` an explicit singleton
> >  . bisect--helper: simplify exit code computation
> >  . bisect--helper: really retire `--bisect-autostart`
> >  . bisect--helper: really retire --bisect-next-check
> >  . bisect--helper: retire the --no-log option
> >  . Merge branch 'sg/parse-options-subcommand' into js/bisect-in-c
> >
> >  Final bits of "git bisect.sh" have been rewritten in C.
> >
> >  Needs review.
> >  cf. <xmqqv8pr8903.fsf@gitster.g>
> >  source: <pull.1132.v6.git.1661885419.gitgitgadget@gmail.com>
>
> I see this has been ejected out of "seen", presumably due to the
> outstanding conflicts.
>
> To the extent that Johannes doesn't have time I'd by happy to re-roll
> this & look at it/fix whatever outstanding issues I spot.
>
> I gave it a once over a few weeks ago, and didn't see any outstanding
> problems with it worth rewriting in that iteration, but didn't have time
> to give it stress testing to see if there were still some lurking
> unexpected/untested behavior changes.
>
> Johannes?

I saw that this was marked as "Needs review." for quite a while. Seeing as
this patch series has been kept out of `next` for quite a few iterations
basically solely due to your concerns (others have said they're fine with
it), I kind of expected you to give a thumbs-up or a thumbs-down (combined
with clear, concise suggestions how to get this moving again).

So now you say that you did not see any outstanding problems? That would
proabably have been good information for Junio to use to move it along
while it did not conflict.

Ciao,
Johannes

      parent reply	other threads:[~2022-11-10 13:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31  5:31 What's cooking in git.git (Oct 2022, #09; Mon, 31) Taylor Blau
2022-10-31 23:44 ` ab/cmake-nix-and-ci (was: What's cooking in git.git (Oct 2022, #09; Mon, 31)) Ævar Arnfjörð Bjarmason
2022-10-31 23:45 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
2022-10-31 23:46 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason
2022-11-01  0:15   ` Taylor Blau
2022-11-02 17:13     ` Ævar Arnfjörð Bjarmason
2022-11-02 17:24       ` Taylor Blau
2022-11-02 16:49 ` What's cooking in git.git (Oct 2022, #09; Mon, 31) Ramsay Jones
2022-11-02 17:22 ` js/bisect-in-c (was: What's cooking in git.git (Oct 2022, #09; Mon, 31)) Ævar Arnfjörð Bjarmason
2022-11-02 17:26   ` Taylor Blau
2022-11-10 13:35     ` Johannes Schindelin
2022-11-11  4:46       ` Taylor Blau
2022-11-11 14:11       ` Ævar Arnfjörð Bjarmason
2022-11-10 13:32   ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s024qpqn-0roo-3rr2-nr4p-74p9296r6p02@tzk.qr \
    --to=johannes.schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).