On Wed, Apr 10, 2019 at 06:18:35PM +0700, Duy Nguyen wrote: > ... Thanks, I tested, and had good results in almost all of my tests. Almost all: config setting of 'pull.rebase=preserve' === $ git submodule foreach --quiet git pull --quiet origin master >/dev/null Successfully rebased and updated detached HEAD. Successfully rebased and updated detached HEAD. $ git pull --rebase --recurse-submodules=yes --quiet >/dev/null $ === Looking at git-rebase--preserve-merges.sh for this message, I think that should be a separate patch to make it respect --quiet. > -- 8< -- (snip patch, please add my DCO signed-off-by) Tested-by: Robin H. Johnson Signed-off-by: Robin H. Johnson > -- 8< -- > > I'm a bit reluctant to follow up with a proper patch because I can't > digest the t5572-submodule-pull.sh tests. And we definitely need to > add a test case about --quiet to make sure it won't happen again. Find testcase attached. Please submit in a series with your patch -- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Treasurer E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136