From: Matthieu Moy <Matthieu.Moy@univ-lyon1.fr>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Matthieu Moy <git@matthieu-moy.fr>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: add test for Linux's get_maintainer.pl
Date: Fri, 05 Jan 2018 12:36:00 +0100 [thread overview]
Message-ID: <q7h9h8s0o7vj.fsf@orange.lip.ens-lyon.fr> (raw)
In-Reply-To: <87o9m8d09u.fsf@linaro.org> ("Alex \=\?utf-8\?Q\?Benn\=C3\=A9e\=22's\?\= message of "Fri, 05 Jan 2018 11:15:41 +0000")
Alex Bennée <alex.bennee@linaro.org> writes:
> I think you need to apply Eric's suggestions from:
>
> From: Eric Sunshine <sunshine@sunshineco.com>
> Date: Sat, 18 Nov 2017 21:54:46 -0500
> Message-ID: <CAPig+cSh0tVVkh0xF9FwCfM4gngAWMSN_FXd2zhzHcy2trYXfw@mail.gmail.com>
Indeed. I'm squashing this into the patch:
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index f126177..d13d8c3 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -173,8 +173,7 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
'
test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' "
- cat >expected-cc-script.sh <<-EOF &&
- #!/bin/sh
+ write_script expected-cc-script.sh <<-EOF &&
echo 'One Person <one@example.com> (supporter:THIS (FOO/bar))'
echo 'Two Person <two@example.com> (maintainer:THIS THING)'
echo 'Third List <three@example.com> (moderated list:THIS THING (FOO/bar))'
@@ -186,7 +185,6 @@ test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer'
"
test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
- test_commit cc-trailer-getmaint &&
clean_fake_sendmail &&
git send-email -1 --to=recipient@example.com \
--cc-cmd="./expected-cc-script.sh" \
--
Matthieu Moy
https://matthieu-moy.fr/
next prev parent reply other threads:[~2018-01-05 11:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 18:55 [RFC PATCH 1/2] add a local copy of Mail::Address from CPAN Matthieu Moy
2018-01-04 18:55 ` [RFC PATCH 2/2] Remove now useless email-address parsing code Matthieu Moy
2018-01-04 22:11 ` Alex Bennée
2018-01-05 9:39 ` Matthieu Moy
2018-01-05 10:11 ` [PATCH] send-email: add test for Linux's get_maintainer.pl Matthieu Moy
2018-01-05 11:15 ` Alex Bennée
2018-01-05 11:36 ` Matthieu Moy [this message]
2018-01-05 20:16 ` Junio C Hamano
2018-01-04 21:02 ` [RFC PATCH 1/2] add a local copy of Mail::Address from CPAN Eric Sunshine
2018-01-05 14:19 ` Ævar Arnfjörð Bjarmason
2018-01-05 18:36 ` [PATCH v2 1/3] send-email: add and use a local copy of Mail::Address Matthieu Moy
2018-01-05 18:36 ` [PATCH v2 2/3] Remove now useless email-address parsing code Matthieu Moy
2018-01-05 18:36 ` [PATCH v2 3/3] send-email: add test for Linux's get_maintainer.pl Matthieu Moy
2018-01-05 18:59 ` Eric Sunshine
2018-01-08 10:30 ` Matthieu Moy
2018-01-08 10:34 ` [PATCH v3 1/3] send-email: add and use a local copy of Mail::Address Matthieu Moy
2018-01-08 10:34 ` [PATCH v3 2/3] Remove now useless email-address parsing code Matthieu Moy
2018-01-08 11:57 ` Alex Bennée
2018-01-08 10:34 ` [PATCH v3 3/3] send-email: add test for Linux's get_maintainer.pl Matthieu Moy
2018-01-08 18:45 ` Junio C Hamano
2018-01-08 11:56 ` [PATCH v3 1/3] send-email: add and use a local copy of Mail::Address Alex Bennée
2018-02-14 14:59 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q7h9h8s0o7vj.fsf@orange.lip.ens-lyon.fr \
--to=matthieu.moy@univ-lyon1.fr \
--cc=alex.bennee@linaro.org \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).