From: "Krushnal Patel via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Krushnal Patel <krushnalpatel11@gmail.com>
Subject: [PATCH v2 0/2] replace test -f with test_path_is_file
Date: Fri, 19 Mar 2021 19:24:51 +0000 [thread overview]
Message-ID: <pull.982.v2.git.git.1616181893.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.982.git.git.1616147527082.gitgitgadget@gmail.com>
Although has the same functionality as test_path_is_file(), in the case
where test_path_is_file() fails, we get much better debugging information.
Replace with test_path_is_file so that future developers will have a better
experience debugging these test cases.
krush11 (2):
replace test -f with test_path_is_file
replaced test -f and test ! -f
t/t7300-clean.sh | 376 +++++++++++++++++++++++------------------------
1 file changed, 188 insertions(+), 188 deletions(-)
base-commit: 576ba9dcdaf1007243f5a5cb4bf1a1e7b8fcf850
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-982%2Fkrush11%2Fnext-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-982/krush11/next-v2
Pull-Request: https://github.com/git/git/pull/982
Range-diff vs v1:
1: e5f92e3882cd = 1: e5f92e3882cd replace test -f with test_path_is_file
-: ------------ > 2: a31a147a34f8 replaced test -f and test ! -f
--
gitgitgadget
next prev parent reply other threads:[~2021-03-19 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:52 [PATCH] replace test -f with test_path_is_file Krushnal Patel via GitGitGadget
2021-03-19 18:04 ` Junio C Hamano
2021-03-19 19:24 ` Krushnal Patel via GitGitGadget [this message]
2021-03-19 19:24 ` [PATCH v2 1/2] " krush11 via GitGitGadget
2021-03-19 19:24 ` [PATCH v2 2/2] replaced test -f and test ! -f krush11 via GitGitGadget
2021-03-19 20:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.982.v2.git.git.1616181893.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=krushnalpatel11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).