git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Hariom Verma <hariom18599@gmail.com>,
	Christian Couder <christian.couder@gmail.com>,
	ZheNing Hu <adlternative@gmail.com>
Subject: [PATCH v4 0/2] [GSOC][RFC] ref-filter: introduce enum atom_type
Date: Thu, 13 May 2021 15:15:36 +0000	[thread overview]
Message-ID: <pull.951.v4.git.1620918939.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.951.v3.git.1620821464.gitgitgadget@gmail.com>

Change from last version: fix some typo error and change commit message with
Junio's help.

ZheNing Hu (2):
  [GSOC] ref-filter: add objectsize to used_atom
  [GSOC] ref-filter: introduce enum atom_type

 ref-filter.c | 214 +++++++++++++++++++++++++++++++++------------------
 1 file changed, 140 insertions(+), 74 deletions(-)


base-commit: 7e391989789db82983665667013a46eabc6fc570
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-951%2Fadlternative%2Fref-filter-atom-type-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-951/adlternative/ref-filter-atom-type-v4
Pull-Request: https://github.com/gitgitgadget/git/pull/951

Range-diff vs v3:

 1:  91ca57c9d04a ! 1:  23fc04f7eb23 [GSOC] ref-filter: add objectsize to used_atom
     @@ Metadata
       ## Commit message ##
          [GSOC] ref-filter: add objectsize to used_atom
      
     -    Since "objectsize:size" is composed of two parts,
     -    "type:attribute". However, the original implementation
     -    did not decouple the two parts "type" and "attribute" well,
     -    we still need to judge separately whether the atom is
     -    "objectsize" or "objectsize:disk" in `grab_common_values()`.
     +    When the support for "objectsize:disk" was bolted onto the
     +    existing support for "objectsize", it didn't follow the
     +    usual pattern for handling "atomtype:modifier", which reads
     +    the <modifier> part just once while parsing the format
     +    string, and store the parsed result in the union in the
     +    used_atom structure, so that the string form of it does not
     +    have to be parsed over and over at runtime (e.g. in
     +    grab_common_values()).
      
          Add a new member `objectsize` to the union `used_atom.u`,
     -    so that we can separate the judgment of atom type from the
     -    judgment of atom attribute, This will bring scalability to
     -    atom `%(objectsize)`.
     +    so that we can separate the check of <modifier> from the
     +    check of <atomtype>, this will bring scalability to atom
     +    `%(objectsize)`.
      
          Signed-off-by: ZheNing Hu <adlternative@gmail.com>
      
 2:  43400cac58e7 ! 2:  50cfe1f0c6c1 [GSOC] ref-filter: introduce enum atom_type
     @@ Commit message
          `used_atom.atom_type` will record corresponding enum value
          from valid_atom entry index, and then in specific reference
          attribute filling step, only need to compare the value of
     -    the `used_atom[i].atom_type` to judge the atom type.
     +    the `used_atom[i].atom_type` to check the atom type.
      
          Helped-by: Junio C Hamano <gitster@pobox.com>
          Helped-by: Christian Couder <christian.couder@gmail.com>
     @@ ref-filter.c: static struct ref_to_worktree_map {
       } ref_to_worktree_map;
       
      +/*
     -+ * The enum atom_type is used as the coordinates of valid_atom entry.
     ++ * The enum atom_type is used as the index of valid_atom array.
      + * In the atom parsing stage, it will be passed to used_atom.atom_type
     -+ * as the identifier of the atom type. We can judge the type of used_atom
     ++ * as the identifier of the atom type. We can check the type of used_atom
      + * entry by `if (used_atom[i].atom_type == ATOM_*)`.
      + */
      +enum atom_type {

-- 
gitgitgadget

  parent reply	other threads:[~2021-05-13 15:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 15:22 [PATCH " ZheNing Hu via GitGitGadget
2021-05-08 15:22 ` [PATCH 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget
2021-05-08 15:22 ` [PATCH 2/2] [GSOC][RFC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget
2021-05-09  6:21   ` Christian Couder
2021-05-09  8:26     ` Junio C Hamano
2021-05-09 13:44       ` ZheNing Hu
2021-05-09 13:40     ` ZheNing Hu
2021-05-10 15:03 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget
2021-05-10 15:03   ` [PATCH v2 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget
2021-05-10 15:03   ` [PATCH v2 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget
2021-05-11  2:14     ` Junio C Hamano
2021-05-11  5:51       ` Christian Couder
2021-05-11  6:12         ` Junio C Hamano
2021-05-11 12:53           ` ZheNing Hu
2021-05-11 12:37         ` ZheNing Hu
2021-05-11 13:05         ` Junio C Hamano
2021-05-11 12:18       ` ZheNing Hu
2021-05-12 12:11   ` [PATCH v3 0/2] [GSOC][RFC] " ZheNing Hu via GitGitGadget
2021-05-12 12:11     ` [PATCH v3 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget
2021-05-12 23:11       ` Junio C Hamano
2021-05-13  9:04         ` ZheNing Hu
2021-05-12 12:11     ` [PATCH v3 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget
2021-05-12 23:21       ` Junio C Hamano
2021-05-13  9:25         ` ZheNing Hu
2021-05-13 15:15     ` ZheNing Hu via GitGitGadget [this message]
2021-05-13 15:15       ` [PATCH v4 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget
2021-05-13 15:15       ` [PATCH v4 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.951.v4.git.1620918939.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=adlternative@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hariom18599@gmail.com \
    --cc=peff@peff.net \
    --subject='Re: [PATCH v4 0/2] [GSOC][RFC] ref-filter: introduce enum atom_type' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).