From: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Brandon Casey" <drafnel@gmail.com>,
"Shourya Shukla" <periperidip@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
"Rafael Silva" <rafaeloliveira.cs@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"ZheNing Hu" <adlternative@gmail.com>
Subject: [PATCH v2 0/2] [GSOC] interpret-trailer: easy parse trailer value
Date: Sun, 21 Mar 2021 08:58:52 +0000 [thread overview]
Message-ID: <pull.911.v2.git.1616317134.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.911.git.1616251299.gitgitgadget@gmail.com>
Hope this can help commit --trailer more useful!
Base on https://github.com/gitgitgadget/git/pull/901, The original patch
series was too long so now split it into two.
Helped by Junio and Jeff, Thanks.
ZheNing Hu (2):
[GSOC] commit: add --trailer option
[GSOC] interpret-trailer: easy parse trailer value
Documentation/git-commit.txt | 14 +-
Documentation/git-interpret-trailers.txt | 23 ++
builtin/commit.c | 55 ++--
commit.c | 34 +++
commit.h | 10 +
t/t7502-commit-porcelain.sh | 319 +++++++++++++++++++++++
t/t7513-interpret-trailers.sh | 23 ++
trailer.c | 13 +-
8 files changed, 456 insertions(+), 35 deletions(-)
base-commit: 13d7ab6b5d7929825b626f050b62a11241ea4945
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-911%2Fadlternative%2Ftrailer-easy-ident-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-911/adlternative/trailer-easy-ident-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/911
Range-diff vs v1:
1: 2378e3b4c1ae = 1: 2378e3b4c1ae [GSOC] commit: add --trailer option
2: ca521d3c01d6 ! 2: 8b8b236a4ffb [GSOC] interpret-trailer: easy parse trailer value
@@ commit.c: int run_commit_hook(int editor_is_used, const char *index_file,
## commit.h ##
@@ commit.h: int parse_buffer_signed_by_header(const char *buffer,
+ struct strbuf *payload,
struct strbuf *signature,
const struct git_hash_algo *algop);
-
++/*
++ * Calling `find_author_by_nickname` to find the "author <email>" pair
++ * in the most recent commit which matches "--author=name".
++ *
++ * Note that `find_author_by_nickname` is not reusable, because it haven't
++ * reset flags for parsed objects. The only safe way to use `find_author_by_nickname`
++ * (without rewriting the revision traversal machinery) is to spawn a
++ * subprocess and do find_author_by_nickname() in it.
++ */
+const char *find_author_by_nickname(const char *name);
-+
+
#endif /* COMMIT_H */
## t/t7502-commit-porcelain.sh ##
--
gitgitgadget
next prev parent reply other threads:[~2021-03-21 9:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 14:41 [PATCH 0/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 21:06 ` Junio C Hamano
2021-03-21 3:29 ` ZheNing Hu
2021-03-21 13:57 ` Junio C Hamano
2021-03-21 14:12 ` ZheNing Hu
2021-03-21 8:58 ` ZheNing Hu via GitGitGadget [this message]
2021-03-21 8:58 ` [PATCH v2 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-21 8:58 ` [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-21 9:17 ` Bagas Sanjaya
2021-03-21 14:04 ` ZheNing Hu
2021-03-21 16:49 ` Junio C Hamano
2021-03-22 6:01 ` Bagas Sanjaya
2021-03-22 18:45 ` Junio C Hamano
2021-03-21 13:15 ` Christian Couder
2021-03-21 13:49 ` ZheNing Hu
2021-03-21 16:52 ` Junio C Hamano
2021-03-22 0:39 ` ZheNing Hu
2021-03-22 7:26 ` Christian Couder
2021-03-22 8:28 ` ZheNing Hu
2021-03-22 17:07 ` Junio C Hamano
2021-03-23 5:04 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.911.v2.git.1616317134.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=bkuhn@sfconservancy.org \
--cc=christian.couder@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=periperidip@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).