From: "Amanda Shafack via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Emily Shaffer <emilyshaffer@google.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Amanda Shafack <shafack.likhene@gmail.com>
Subject: [PATCH 0/2] [Outreachy][Patch v1] t9832,t2200: avoid using pipes in git related commands
Date: Sat, 17 Oct 2020 16:02:30 +0000 [thread overview]
Message-ID: <pull.885.git.git.1602950552.gitgitgadget@gmail.com> (raw)
When the upstream of a pipe throws an error, the downstream still executes
normally. This happens because the exit code of the upstream in a pipe is
ignored. This behavior can make debugging very hard in case a test fails.
Also, pipes are prone to deadlocks. If the upstream gets full, the commands
downstream will never start.
Write out the output of the git command to a file, so as to test the exit
codes of both commands.
Commit c6f44e1da5 (t9813: avoid using pipes, 2017-01-04) noticed that the
exit code of upstream in the pipe is ignored, thus using pipes should be
avoided.
Signed-off-by: Amanda Shafack shafack.likhene@gmail.com
[shafack.likhene@gmail.com]
Amanda Shafack (1):
t2200: modify code syntax
Amanda Shafack (1):
t9832,t2200: avoid using pipes in git commands
t/t2200-add-update.sh | 3 ++-
t/t9832-unshelve.sh | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
base-commit: a5fa49ff0a8f3252c6bff49f92b85e7683868f8a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-885%2Flkmandy%2Favoid-pipes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-885/lkmandy/avoid-pipes-v1
Pull-Request: https://github.com/git/git/pull/885
--
gitgitgadget
next reply other threads:[~2020-10-17 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 16:02 Amanda Shafack via GitGitGadget [this message]
2020-10-17 16:02 ` [PATCH 1/2] t9832,t2200: avoid using pipes in git commands Amanda Shafack via GitGitGadget
2020-10-18 6:11 ` Eric Sunshine
2020-10-18 13:57 ` Amanda Shafack
2020-10-17 16:02 ` [PATCH 2/2] t2200: modify code syntax Amanda Shafack via GitGitGadget
2020-10-18 5:55 ` Eric Sunshine
2020-10-18 13:59 ` Amanda Shafack
2020-10-18 14:42 ` [PATCH v2] t9832,t2200: avoid using pipes in git commands Amanda Shafack via GitGitGadget
2020-10-18 19:25 ` Eric Sunshine
2020-10-18 20:04 ` Junio C Hamano
2020-10-18 22:04 ` Amanda Shafack
2020-10-18 20:40 ` Amanda Shafack
2020-10-18 20:48 ` [PATCH v3] t2200,t9832: avoid using 'git' upstream in a pipe Amanda Shafack via GitGitGadget
2020-10-18 21:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.885.git.git.1602950552.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=shafack.likhene@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).