From: "阿德烈 via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>, 阿德烈 <adlternative@gmail.com>
Subject: [PATCH v3 0/2] builtin/*: update usage format
Date: Wed, 06 Jan 2021 14:44:01 +0000 [thread overview]
Message-ID: <pull.822.v3.git.1609944243.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.822.v2.git.1609933875.gitgitgadget@gmail.com>
According to the "Error Messages" section of Documentation/CodingGuidelines,
we should not end in a full stop or start with a capital letter. Fix old
error and usage messages to match this expectation.
Signed-off-by: adl 1607364851@qq.com
Junio C Hamano (1):
parse-options: format argh like error messages
ZheNing Hu (1):
builtin/*: update usage format
builtin/am.c | 4 ++--
builtin/blame.c | 48 ++++++++++++++++++-------------------
builtin/commit-graph.c | 6 ++---
builtin/fast-export.c | 22 ++++++++---------
builtin/log.c | 8 +++----
builtin/shortlog.c | 10 ++++----
builtin/submodule--helper.c | 24 +++++++++----------
parse-options.h | 6 ++---
8 files changed, 64 insertions(+), 64 deletions(-)
base-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-822%2Fadlternative%2Fdev-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-822/adlternative/dev-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/822
Range-diff vs v2:
2: c5f01b0eab1 ! 1: 9d508df032b parse-options: format argh like error messages
@@ Commit message
Noticed-by: ZheNing Hu <adlternative@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
+ Signed-off-by: ZheNing Hu <adlternative@gmail.com>
## parse-options.h ##
@@ parse-options.h: typedef enum parse_opt_result parse_opt_ll_cb(struct parse_opt_ctx_t *ctx,
1: 52f7c8457dd ! 2: d3eb6dcff14 builtin/*: update usage format
@@ Metadata
## Commit message ##
builtin/*: update usage format
- According to the "Error Messages" section of
- Documentation/CodingGuidelines, we should not end in a full
- stop or start with a capital letter. Fix old error and usage
+ According to the guidelines in parse-options.h,
+ we should not end in a full stop or start with
+ a capital letter. Fix old error and usage
messages to match this expectation.
Signed-off-by: ZheNing Hu <adlternative@gmail.com>
--
gitgitgadget
next prev parent reply other threads:[~2021-01-06 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 8:55 [PATCH] builtin/*: update usage format 阿德烈 via GitGitGadget
2020-12-29 14:33 ` Felipe Contreras
2021-01-06 7:05 ` Re* " Junio C Hamano
2021-01-06 12:03 ` Derrick Stolee
2021-01-06 11:51 ` [PATCH v2 0/2] " 阿德烈 via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 1/2] " ZheNing Hu via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 2/2] parse-options: format argh like error messages Junio C Hamano via GitGitGadget
2021-01-06 12:05 ` Derrick Stolee
2021-01-06 14:44 ` 阿德烈 via GitGitGadget [this message]
2021-01-06 14:44 ` [PATCH v3 1/2] " Junio C Hamano via GitGitGadget
2021-01-06 14:44 ` [PATCH v3 2/2] builtin/*: update usage format ZheNing Hu via GitGitGadget
2021-01-06 23:14 ` [PATCH v3 0/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.822.v3.git.1609944243.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=adlternative@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).