From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> To: git@vger.kernel.org Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, Johannes Schindelin <johannes.schindelin@gmx.de>, Johannes Schindelin <johannes.schindelin@gmx.de> Subject: [PATCH v2] t4015: let the test pass with any default branch name Date: Wed, 18 Nov 2020 23:35:44 +0000 Message-ID: <pull.794.v2.git.1605742544801.gitgitgadget@gmail.com> (raw) In-Reply-To: <pull.794.git.1605727594021.gitgitgadget@gmail.com> From: Johannes Schindelin <johannes.schindelin@gmx.de> We do not need to hard-code the actual branch name, as we can use the `test_commit` function to simplify the code and use the tag it generates, thereby being a lot more precise in what we want. Strangely enough, this test case would have succeeded even with an overridden default branch name, obviously for the wrong reason. Let's verify that it passes for the expected reason, by looking for a tell-tale in Git's output. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t4015: let the test pass with any default branch name Aaaaand another issue, also found while working on https://github.com/gitgitgadget/git/pull/762. Changes since v1: * We now use test_commit and the tag it creates, rather than the reflog. * Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-794%2Fdscho%2Ft4015-and-default-branch-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-794/dscho/t4015-and-default-branch-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/794 Range-diff vs v1: 1: 5467cae0dd ! 1: 2f6d07fe90 t4015: let the test pass with any default branch name @@ Metadata ## Commit message ## t4015: let the test pass with any default branch name - We do not need to hard-code the actual branch name, as we have access to - the reflog and can be a lot more precise at what we want. + We do not need to hard-code the actual branch name, as we can use the + `test_commit` function to simplify the code and use the tag it + generates, thereby being a lot more precise in what we want. Strangely enough, this test case would have succeeded even with an overridden default branch name, obviously for the wrong reason. Let's @@ Commit message Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ## t/t4015-diff-whitespace.sh ## -@@ t/t4015-diff-whitespace.sh: test_expect_success 'combined diff with autocrlf conversion' ' +@@ t/t4015-diff-whitespace.sh: test_expect_success 'rename empty' ' + test_expect_success 'combined diff with autocrlf conversion' ' + + git reset --hard && +- echo >x hello && +- git commit -m "one side" x && ++ test_commit "one side" x hello one-side && + git checkout HEAD^ && echo >x goodbye && git commit -m "the other side" x && git config core.autocrlf true && - test_must_fail git merge master && -+ test_must_fail git merge @{2} >actual && ++ test_must_fail git merge one-side >actual && + test_i18ngrep "Automatic merge failed" actual && git diff >actual.raw && t/t4015-diff-whitespace.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh index 8bdaa0a693..47f0e2889d 100755 --- a/t/t4015-diff-whitespace.sh +++ b/t/t4015-diff-whitespace.sh @@ -877,13 +877,13 @@ test_expect_success 'rename empty' ' test_expect_success 'combined diff with autocrlf conversion' ' git reset --hard && - echo >x hello && - git commit -m "one side" x && + test_commit "one side" x hello one-side && git checkout HEAD^ && echo >x goodbye && git commit -m "the other side" x && git config core.autocrlf true && - test_must_fail git merge master && + test_must_fail git merge one-side >actual && + test_i18ngrep "Automatic merge failed" actual && git diff >actual.raw && sed -e "1,/^@@@/d" actual.raw >actual && base-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500 -- gitgitgadget
prev parent reply other threads:[~2020-11-18 23:39 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 19:26 [PATCH] " Johannes Schindelin via GitGitGadget 2020-11-18 20:20 ` Junio C Hamano 2020-11-18 23:13 ` Johannes Schindelin 2020-11-18 23:35 ` Johannes Schindelin via GitGitGadget [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=pull.794.v2.git.1605742544801.gitgitgadget@gmail.com \ --to=gitgitgadget@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --subject='Re: [PATCH v2] t4015: let the test pass with any default branch name' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git