From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Derrick Stolee <stolee@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH v3 0/2] Explicitly fflush stdout in git clean
Date: Fri, 10 Apr 2020 18:16:52 +0000 [thread overview]
Message-ID: <pull.755.v3.git.git.1586542614.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.755.v2.git.git.1586518072.gitgitgadget@gmail.com>
This is yet another patch that was funneled through a Git for Windows PR,
read: it has been battle-tested.
Of course, the current iteration of this patch series has not been
battle-tested, so please do review carefully, so that we can prevent bugs
from slipping in during the review process.
Changes since v2:
* Fixed the capitalization of "THerefore" in the commit message.
Changes since v1:
* Added a preparatory patch that refactors all interactive input reading
via strbuf_getline(..., stdin).
* Adjusted the patch and its commit message accordingly.
Johannes Schindelin (1):
Refactor code asking the user for input interactively
마누엘 (1):
Explicitly `fflush` stdout before expecting interactive input
add-interactive.c | 4 ++--
add-patch.c | 4 ++--
builtin/clean.c | 14 ++++----------
prompt.c | 12 ++++++++++++
prompt.h | 2 ++
shell.c | 4 ++--
6 files changed, 24 insertions(+), 16 deletions(-)
base-commit: 9fadedd637b312089337d73c3ed8447e9f0aa775
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-755%2Fdscho%2Ffflush-in-git-clean-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-755/dscho/fflush-in-git-clean-v3
Pull-Request: https://github.com/git/git/pull/755
Range-diff vs v2:
1: 9d2ee78a9e4 ! 1: 072f95090ae Refactor code asking the user for input interactively
@@ Commit message
beginning and at the end of the answer, instead of trimming only the
end (as the caller in `add-patch.c` does).
- THerefore, technically speaking, we change behavior in this patch. At
+ Therefore, technically speaking, we change behavior in this patch. At
the same time, it can be argued that this is actually a bug fix.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2: d3949e42004 = 2: 063d2aaa401 Explicitly `fflush` stdout before expecting interactive input
--
gitgitgadget
next prev parent reply other threads:[~2020-04-10 18:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 19:33 [PATCH] clean: explicitly `fflush` stdout Johannes Schindelin via GitGitGadget
2020-04-08 20:14 ` Jeff King
2020-04-08 21:51 ` Junio C Hamano
2020-04-08 22:38 ` Jeff King
2020-04-10 14:03 ` Johannes Schindelin
2020-04-10 11:27 ` [PATCH v2 0/2] Explicitly fflush stdout in git clean Johannes Schindelin via GitGitGadget
2020-04-10 11:27 ` [PATCH v2 1/2] Refactor code asking the user for input interactively Johannes Schindelin via GitGitGadget
2020-04-10 12:27 ` Derrick Stolee
2020-04-10 14:01 ` Johannes Schindelin
2020-04-10 15:07 ` Jeff King
2020-04-10 17:44 ` Junio C Hamano
2020-04-10 11:27 ` [PATCH v2 2/2] Explicitly `fflush` stdout before expecting interactive input 마누엘 via GitGitGadget
2020-04-10 12:28 ` Derrick Stolee
2020-04-10 18:16 ` Johannes Schindelin via GitGitGadget [this message]
2020-04-10 18:16 ` [PATCH v3 1/2] Refactor code asking the user for input interactively Johannes Schindelin via GitGitGadget
2020-04-10 18:16 ` [PATCH v3 2/2] Explicitly `fflush` stdout before expecting interactive input 마누엘 via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.755.v3.git.git.1586542614.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).