git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/3] mingw: require Windows Vista or later (and fix the Windows CI builds)
Date: Wed, 03 Oct 2018 12:43:39 -0700 (PDT)	[thread overview]
Message-ID: <pull.44.git.gitgitgadget@gmail.com> (raw)

I noticed that a recent GitGitGadget build failed in the Windows phase, with
compat/poll/poll.h problems all over the place.

Turns out that this is caused by the recent upgrade of the mingw-w64 headers
and crt files (7.0.0.5233.e0c09544 -> 7.0.0.5245.edf66197, which I assume
now enforces Vista as minimal Windows version also for all mingw-w64
projects).

Luckily, in Git for Windows' master, we already had changes to require Vista
(for unrelated reasons: to restrict the std handle inheritance when spawning
new processes).

Technically, Windows Vista is already no longer supported
[https://support.microsoft.com/en-us/help/22882/windows-vista-end-of-support]
, but we do try to keep Git building on older Windows version, up until the
point when it becomes too big of a maintenance burden.

Johannes Schindelin (3):
  compat/poll: prepare for targeting Windows Vista
  mingw: set _WIN32_WINNT explicitly for Git for Windows
  mingw: bump the minimum Windows version to Vista

 compat/poll/poll.c |  6 +++---
 compat/poll/poll.h | 15 +++++++++++++++
 config.mak.uname   |  4 ----
 git-compat-util.h  |  4 ++--
 4 files changed, 20 insertions(+), 9 deletions(-)


base-commit: fe8321ec057f9231c26c29b364721568e58040f7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-44%2Fdscho%2Frequire-windows-vista-or-later-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-44/dscho/require-windows-vista-or-later-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/44
-- 
gitgitgadget

             reply	other threads:[~2018-10-03 19:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 19:43 Johannes Schindelin via GitGitGadget [this message]
2018-10-03 19:43 ` [PATCH 1/3] compat/poll: prepare for targeting Windows Vista Johannes Schindelin via GitGitGadget
2018-10-03 19:43 ` [PATCH 2/3] mingw: set _WIN32_WINNT explicitly for Git for Windows Johannes Schindelin via GitGitGadget
2018-10-03 19:43 ` [PATCH 3/3] mingw: bump the minimum Windows version to Vista Johannes Schindelin via GitGitGadget
2018-10-10 14:08   ` Ævar Arnfjörð Bjarmason
2018-10-11  6:24     ` Junio C Hamano
2019-10-14 11:46       ` Johannes Schindelin
2019-10-14 11:58         ` Johannes Schindelin
2019-10-14 11:54     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.44.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).