* [PATCH 0/1] doc: small formatting fix
@ 2019-09-09 23:21 Cameron Steffen via GitGitGadget
2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Cameron Steffen via GitGitGadget @ 2019-09-09 23:21 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
Edit: I need permission to submit please
Cameron Steffen (1):
doc: small formatting fix
Documentation/pretty-formats.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/330
--
gitgitgadget
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/1] doc: small formatting fix 2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget @ 2019-09-09 23:21 ` Cameron Steffen via GitGitGadget 2019-09-11 11:50 ` Derrick Stolee 2019-09-11 21:24 ` Johannes Schindelin 2019-09-11 11:49 ` [PATCH 0/1] " Derrick Stolee ` (2 subsequent siblings) 3 siblings, 2 replies; 9+ messages in thread From: Cameron Steffen via GitGitGadget @ 2019-09-09 23:21 UTC (permalink / raw) To: git; +Cc: Junio C Hamano, Cameron Steffen From: Cameron Steffen <cam.steffen94@gmail.com> move an incorrectly placed backtick Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> --- Documentation/pretty-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt index 079598307a..b87e2e83e6 100644 --- a/Documentation/pretty-formats.txt +++ b/Documentation/pretty-formats.txt @@ -208,7 +208,7 @@ endif::git-rev-list[] '%GP':: show the fingerprint of the primary key whose subkey was used to sign a signed commit '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 - minutes ago`}; the format follows the rules described for the + minutes ago}`; the format follows the rules described for the `-g` option. The portion before the `@` is the refname as given on the command line (so `git log -g refs/heads/master` would yield `refs/heads/master@{0}`). -- gitgitgadget ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] doc: small formatting fix 2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget @ 2019-09-11 11:50 ` Derrick Stolee 2019-09-11 21:24 ` Johannes Schindelin 1 sibling, 0 replies; 9+ messages in thread From: Derrick Stolee @ 2019-09-11 11:50 UTC (permalink / raw) To: Cameron Steffen via GitGitGadget, git; +Cc: Junio C Hamano, Cameron Steffen On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote: > From: Cameron Steffen <cam.steffen94@gmail.com> > > move an incorrectly placed backtick The change below is simple enough, but we prefer using full sentences in the commit messages. This includes capitalization and punctuation. Thanks, -Stolee > Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> > --- > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 079598307a..b87e2e83e6 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -208,7 +208,7 @@ endif::git-rev-list[] > '%GP':: show the fingerprint of the primary key whose subkey was used > to sign a signed commit > '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 > - minutes ago`}; the format follows the rules described for the > + minutes ago}`; the format follows the rules described for the > `-g` option. The portion before the `@` is the refname as > given on the command line (so `git log -g refs/heads/master` > would yield `refs/heads/master@{0}`). > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] doc: small formatting fix 2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget 2019-09-11 11:50 ` Derrick Stolee @ 2019-09-11 21:24 ` Johannes Schindelin 1 sibling, 0 replies; 9+ messages in thread From: Johannes Schindelin @ 2019-09-11 21:24 UTC (permalink / raw) To: Cameron Steffen via GitGitGadget; +Cc: git, Junio C Hamano, Cameron Steffen Hi Cameron, On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote: > From: Cameron Steffen <cam.steffen94@gmail.com> > > move an incorrectly placed backtick This sentence is incomplete, and does not really explain _why_ the backtick needs to be moved. Something like this would be much clearer: Most likely by mistake, the closing curly brace was added _after_ the backtick instead of _before_ it. This breaks the formatting. Let's fix that. The patch looks good, though. To send another iteration of this patch, amend your commit locally, force-push, and issue another `/submit`. Ciao, Johannes > > Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> > --- > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 079598307a..b87e2e83e6 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -208,7 +208,7 @@ endif::git-rev-list[] > '%GP':: show the fingerprint of the primary key whose subkey was used > to sign a signed commit > '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 > - minutes ago`}; the format follows the rules described for the > + minutes ago}`; the format follows the rules described for the > `-g` option. The portion before the `@` is the refname as > given on the command line (so `git log -g refs/heads/master` > would yield `refs/heads/master@{0}`). > -- > gitgitgadget > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/1] doc: small formatting fix 2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget 2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget @ 2019-09-11 11:49 ` Derrick Stolee 2019-09-11 14:52 ` [PATCH v2 " Cameron Steffen via GitGitGadget 2019-09-11 21:21 ` [PATCH 0/1] doc: small " Johannes Schindelin 3 siblings, 0 replies; 9+ messages in thread From: Derrick Stolee @ 2019-09-11 11:49 UTC (permalink / raw) To: Cameron Steffen via GitGitGadget, git; +Cc: Junio C Hamano On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote: > Edit: I need permission to submit please Hi Cameron. When using GitGitGadget, your PR description becomes your cover letter on the mailing list. This is a great place for you to describe how you discovered this problem and if you have looked elsewhere for similar issues to fix up. Thanks, -Stolee > > Cameron Steffen (1): > doc: small formatting fix > > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/330 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 0/1] doc: small formatting fix 2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget 2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget 2019-09-11 11:49 ` [PATCH 0/1] " Derrick Stolee @ 2019-09-11 14:52 ` Cameron Steffen via GitGitGadget 2019-09-11 14:52 ` [PATCH v2 1/1] doc: minor " Cameron Steffen via GitGitGadget 2019-09-11 21:21 ` [PATCH 0/1] doc: small " Johannes Schindelin 3 siblings, 1 reply; 9+ messages in thread From: Cameron Steffen via GitGitGadget @ 2019-09-11 14:52 UTC (permalink / raw) To: git; +Cc: Junio C Hamano Move a closing backtick that was placed one character too soon. Cameron Steffen (1): doc: minor formatting fix Documentation/pretty-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/330 Range-diff vs v1: 1: 5248e3332c ! 1: 8e64007452 doc: small formatting fix @@ -1,8 +1,8 @@ Author: Cameron Steffen <cam.steffen94@gmail.com> - doc: small formatting fix + doc: minor formatting fix - move an incorrectly placed backtick + Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> -- gitgitgadget ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] doc: minor formatting fix 2019-09-11 14:52 ` [PATCH v2 " Cameron Steffen via GitGitGadget @ 2019-09-11 14:52 ` Cameron Steffen via GitGitGadget 2019-09-12 18:06 ` Junio C Hamano 0 siblings, 1 reply; 9+ messages in thread From: Cameron Steffen via GitGitGadget @ 2019-09-11 14:52 UTC (permalink / raw) To: git; +Cc: Junio C Hamano, Cameron Steffen From: Cameron Steffen <cam.steffen94@gmail.com> Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> --- Documentation/pretty-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt index 079598307a..b87e2e83e6 100644 --- a/Documentation/pretty-formats.txt +++ b/Documentation/pretty-formats.txt @@ -208,7 +208,7 @@ endif::git-rev-list[] '%GP':: show the fingerprint of the primary key whose subkey was used to sign a signed commit '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 - minutes ago`}; the format follows the rules described for the + minutes ago}`; the format follows the rules described for the `-g` option. The portion before the `@` is the refname as given on the command line (so `git log -g refs/heads/master` would yield `refs/heads/master@{0}`). -- gitgitgadget ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] doc: minor formatting fix 2019-09-11 14:52 ` [PATCH v2 1/1] doc: minor " Cameron Steffen via GitGitGadget @ 2019-09-12 18:06 ` Junio C Hamano 0 siblings, 0 replies; 9+ messages in thread From: Junio C Hamano @ 2019-09-12 18:06 UTC (permalink / raw) To: Cameron Steffen via GitGitGadget; +Cc: git, Cameron Steffen "Cameron Steffen via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Cameron Steffen <cam.steffen94@gmail.com> > > Move a closing backtick that was placed one character too soon. > > Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com> > --- > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for spotting and fixing. Will apply. > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 079598307a..b87e2e83e6 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -208,7 +208,7 @@ endif::git-rev-list[] > '%GP':: show the fingerprint of the primary key whose subkey was used > to sign a signed commit > '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2 > - minutes ago`}; the format follows the rules described for the > + minutes ago}`; the format follows the rules described for the > `-g` option. The portion before the `@` is the refname as > given on the command line (so `git log -g refs/heads/master` > would yield `refs/heads/master@{0}`). ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/1] doc: small formatting fix 2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget ` (2 preceding siblings ...) 2019-09-11 14:52 ` [PATCH v2 " Cameron Steffen via GitGitGadget @ 2019-09-11 21:21 ` Johannes Schindelin 3 siblings, 0 replies; 9+ messages in thread From: Johannes Schindelin @ 2019-09-11 21:21 UTC (permalink / raw) To: Cameron Steffen via GitGitGadget; +Cc: git, Junio C Hamano Hi Cameron, On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote: > Edit: I need permission to submit please You got that permission already ;-) Ciao, Johannes > > Cameron Steffen (1): > doc: small formatting fix > > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/330 > -- > gitgitgadget > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-12 18:06 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget 2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget 2019-09-11 11:50 ` Derrick Stolee 2019-09-11 21:24 ` Johannes Schindelin 2019-09-11 11:49 ` [PATCH 0/1] " Derrick Stolee 2019-09-11 14:52 ` [PATCH v2 " Cameron Steffen via GitGitGadget 2019-09-11 14:52 ` [PATCH v2 1/1] doc: minor " Cameron Steffen via GitGitGadget 2019-09-12 18:06 ` Junio C Hamano 2019-09-11 21:21 ` [PATCH 0/1] doc: small " Johannes Schindelin
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).