From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] upload-pack: fix race condition in t5516
Date: Tue, 27 Aug 2019 18:43:29 -0700 (PDT) [thread overview]
Message-ID: <pull.324.git.gitgitgadget@gmail.com> (raw)
This patch fixes a strange race condition that was hitting our PR builds on
microsoft/git rather frequently. See [1] for an example.
It was only happening on the MSVC builds, so somehow that compiler/platform
combination was leading to this race condition happening more often than
other platforms. See the commit message for the race condition.
The thing I am worried about is that I replaced a die() statement with an
error() and exit() pair. Is that OK? Or is there a preferred option?
Thanks, -Stolee
[1] https://gvfs.visualstudio.com/ci/_build/results?buildId=16068
Derrick Stolee (1):
upload-pack: fix race condition in error messages
upload-pack.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-324%2Fderrickstolee%2Ft5516-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-324/derrickstolee/t5516-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/324
--
gitgitgadget
next reply other threads:[~2019-08-28 1:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 1:43 Derrick Stolee via GitGitGadget [this message]
2019-08-28 1:43 ` [PATCH 1/1] upload-pack: fix race condition in error messages Derrick Stolee via GitGitGadget
2019-08-28 9:34 ` SZEDER Gábor
2019-08-28 14:54 ` Jeff King
2019-08-28 15:39 ` Jeff King
2019-08-28 16:15 ` SZEDER Gábor
2019-08-29 12:58 ` Derrick Stolee
2019-08-29 14:13 ` Jeff King
2019-08-29 14:27 ` Derrick Stolee
2019-08-29 14:38 ` Jeff King
2019-08-29 21:58 ` SZEDER Gábor
2019-08-29 22:06 ` SZEDER Gábor
2019-08-30 12:10 ` SZEDER Gábor
2019-09-04 5:04 ` Jeff King
2019-09-10 12:08 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.324.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).