git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Morian Sonnet via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/1] submodule foreach: fix recursion of options
Date: Wed, 12 Jun 2019 13:28:13 -0700 (PDT)	[thread overview]
Message-ID: <pull.263.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.263.git.gitgitgadget@gmail.com>

During the usage of git in Buildkite we noted that git fails upon calling 
git submodule foreach --recursive git reset --hardafter updating git version
to 2.22.0.

This is due to a problem with the recursive calling of git submodule--helper 
itself, which is fixed in the patch below.

Morian Sonnet (1):
  submodule foreach: fix recursion of options

 builtin/submodule--helper.c  | 1 +
 t/t7407-submodule-foreach.sh | 7 +++++++
 2 files changed, 8 insertions(+)


base-commit: b697d92f56511e804b8ba20ccbe7bdc85dc66810
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-263%2Fmomoson%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-263/momoson/master-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/263

Range-diff vs v1:

 1:  e766e51777 ! 1:  c46e5bd140 submodule foreach: fix recursion of options
     @@ -65,8 +65,10 @@
       '
       
      +test_expect_success 'option-like arguments passed to foreach recurse correctly' '
     -+  cd super &&
     -+  git submodule foreach --recursive git reset --hard
     ++  (
     ++    cd super &&
     ++    git submodule foreach --recursive git reset --hard
     ++  )
      +'
      +
       test_done

-- 
gitgitgadget

  parent reply	other threads:[~2019-06-12 20:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 18:10 [PATCH 0/1] submodule foreach: fix recursion of options Morian Sonnet via GitGitGadget
2019-06-12 18:10 ` [PATCH 1/1] " Morian Sonnet via GitGitGadget
2019-06-12 19:35   ` Eric Sunshine
2019-06-12 20:28 ` Morian Sonnet via GitGitGadget [this message]
2019-06-12 20:28   ` [PATCH v2 " Morian Sonnet via GitGitGadget
2019-06-18 15:15     ` Morian Sonnet
2019-06-19 18:19       ` Johannes Schindelin
2019-06-22 10:54         ` Morian Sonnet
2019-06-24 10:49           ` Johannes Schindelin
2019-06-24 15:40             ` Morian Sonnet
2019-06-24 15:40             ` [PATCH] " Morian Sonnet
2019-06-24 15:47               ` Morian Sonnet
2019-06-24 15:47               ` [PATCH] " Morian Sonnet
2019-06-24 17:47                 ` Johannes Schindelin
2019-06-24 18:16                 ` Junio C Hamano
2019-06-24 20:26                   ` Morian Sonnet
2019-06-24 20:26                   ` [PATCH] " Morian Sonnet
2019-06-25 11:18                     ` Duy Nguyen
2019-06-25 18:18                       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.263.v2.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).