From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] Fix an off-by-one bug in the untracked cache code
Date: Wed, 10 Apr 2019 05:56:47 -0700 (PDT) [thread overview]
Message-ID: <pull.178.git.gitgitgadget@gmail.com> (raw)
Frankly, I am surprised it took me this long to discover this bug, as I am
running with the untracked cache for ages now.
But as of recent, I am running more and more long-running commands, mostly
rebases to keep what I call "ever-green" branches up to date, where Git for
Windows' patch thicket is rebased onto core Git's four integration branches,
and when there are no merge conflicts to stop the rebase early, I got this
really obscure crash (no error message, no nothing to indicate what it was).
It cost me two full work days to chase this one down.
Johannes Schindelin (1):
untracked cache: fix off-by-one
dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: e35b8cb8e212e3557efc565157ceb5cbaaf0d87f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-178%2Fdscho%2Funtracked-cache-off-by-one-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-178/dscho/untracked-cache-off-by-one-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/178
--
gitgitgadget
next reply other threads:[~2019-04-10 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 12:56 Johannes Schindelin via GitGitGadget [this message]
2019-04-10 12:56 ` [PATCH 1/1] untracked cache: fix off-by-one Johannes Schindelin via GitGitGadget
2019-04-10 16:20 ` Jeff King
2019-04-12 1:48 ` Junio C Hamano
2019-04-18 21:14 ` [PATCH 0/3] untracked cache parsing fixups Jeff King
2019-04-18 21:17 ` [PATCH 1/3] untracked-cache: be defensive about missing NULs in index Jeff King
2019-04-19 5:29 ` Junio C Hamano
2019-04-18 21:17 ` [PATCH 2/3] untracked-cache: simplify parsing by dropping "next" Jeff King
2019-04-19 5:33 ` Junio C Hamano
2019-04-18 21:18 ` [PATCH 3/3] untracked-cache: simplify parsing by dropping "len" Jeff King
2019-04-18 21:24 ` [PATCH 4/3] untracked-cache: use FLEX_ALLOC to create internal structs Jeff King
2019-04-19 9:18 ` Duy Nguyen
2019-04-19 19:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.178.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).