From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/8] Assorted Documentation-related fixes
Date: Thu, 18 Apr 2019 06:16:37 -0700 (PDT) [thread overview]
Message-ID: <pull.168.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.168.git.gitgitgadget@gmail.com>
While working on better support for make check-docs on Windows, I noticed a
couple more things, e.g. some "commands" were reported as being listed but
not built, e.g. gitcli (i.e. the parts of command-list.txt that are marked
as "guide").
This patch series cleans up those loose ends: after this, make check-docs
reports no issues on Windows.
Changes since v1:
* There is now an extra patch that gets rid of the NO_INSTALL variable in
the Makefile altogether.
* The generate-cmdlist.sh patch now results in more robust code (thanks,
Junio!).
* Patch 2/7 has a much better commit message now, and instead of filtering
out excluded commands from the command-list.txt, it expects excluded
commands by looking not only at $(ALL_COMMANDS) but also at
$(EXCLUDED_PROGRAMS).
* Instead of the fragile logic to generate
Documentation/GIT-EXCLUDED-PROGRAMS that I hoped would let me get away
with less work, I now imitate the logic of GIT-CFLAGS (and the resulting
patch is actually a lot easier to read).
Johannes Schindelin (8):
remote-testgit: move it into the support directory for t5801
Makefile: drop the NO_INSTALL variable
help -a: do not list commands that are excluded from the build
check-docs: allow command-list.txt to contain excluded commands
docs: exclude documentation for commands that have been excluded
check-docs: do not bother checking for legacy scripts' documentation
test-tool: handle the `-C <directory>` option just like `git`
Turn `git serve` into a test helper
.gitignore | 1 -
Documentation/.gitignore | 1 +
Documentation/Makefile | 3 ++
Makefile | 53 +++++++++++--------
builtin.h | 1 -
generate-cmdlist.sh | 10 +++-
git.c | 1 -
builtin/serve.c => t/helper/test-serve-v2.c | 7 +--
t/helper/test-tool.c | 20 +++++++
t/helper/test-tool.h | 1 +
t/t5701-git-serve.sh | 32 ++++++-----
t/t5702-protocol-v2.sh | 5 +-
t/t5703-upload-pack-ref-in-want.sh | 16 +++---
t/t5801-remote-helpers.sh | 2 +
.../t5801/git-remote-testgit | 0
15 files changed, 101 insertions(+), 52 deletions(-)
rename builtin/serve.c => t/helper/test-serve-v2.c (81%)
rename git-remote-testgit.sh => t/t5801/git-remote-testgit (100%)
base-commit: 5ee42463399ca3cc75b7e6e4368a3a5df5b010f2
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-168%2Fdscho%2Fdocs-misc-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-168/dscho/docs-misc-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/168
Range-diff vs v1:
1: 81c08b178b = 1: 81c08b178b remote-testgit: move it into the support directory for t5801
-: ---------- > 2: fda0b10c84 Makefile: drop the NO_INSTALL variable
2: 7dc5293e9e ! 3: 9b498a6f21 help -a: do not list commands that are excluded from the build
@@ -70,7 +70,7 @@
command_list () {
- grep -v '^#' "$1"
-+ eval grep -ve '^#' $exclude_programs "$1"
++ eval "grep -ve '^#' $exclude_programs" <"$1"
}
get_categories () {
@@ -79,7 +79,7 @@
}
+exclude_programs=
-+while test "a$1" = "a--exclude-program"
++while test "--exclude-program" = "$1"
+do
+ shift
+ exclude_programs="$exclude_programs -e \"^$1 \""
3: 96ced7e17c < -: ---------- check-docs: do not pretend that commands are listed which are excluded
4: 31d8e43cbf < -: ---------- docs: exclude documentation for commands that have been excluded
-: ---------- > 4: ac3670a805 check-docs: allow command-list.txt to contain excluded commands
-: ---------- > 5: f8d133c597 docs: exclude documentation for commands that have been excluded
5: fb3daa6427 = 6: 05d4ad62d6 check-docs: do not bother checking for legacy scripts' documentation
6: 2e19f538bc = 7: cf73021574 test-tool: handle the `-C <directory>` option just like `git`
7: 411587e4b8 = 8: 88a5ab2332 Turn `git serve` into a test helper
--
gitgitgadget
next prev parent reply other threads:[~2019-04-18 13:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 12:00 [PATCH 0/7] Assorted Documentation-related fixes Johannes Schindelin via GitGitGadget
2019-04-12 12:00 ` [PATCH 1/7] remote-testgit: move it into the support directory for t5801 Johannes Schindelin via GitGitGadget
2019-04-15 7:08 ` Junio C Hamano
2019-04-18 11:46 ` Johannes Schindelin
2019-04-12 12:00 ` [PATCH 2/7] help -a: do not list commands that are excluded from the build Johannes Schindelin via GitGitGadget
2019-04-15 7:08 ` Junio C Hamano
2019-04-18 12:06 ` Johannes Schindelin
2019-04-12 12:00 ` [PATCH 3/7] check-docs: do not pretend that commands are listed which are excluded Johannes Schindelin via GitGitGadget
2019-04-15 7:18 ` Junio C Hamano
2019-04-18 12:41 ` Johannes Schindelin
2019-04-12 12:00 ` [PATCH 4/7] docs: exclude documentation for commands that have been excluded Johannes Schindelin via GitGitGadget
2019-04-12 18:46 ` Eric Sunshine
2019-04-15 3:09 ` Junio C Hamano
2019-04-15 4:16 ` Eric Sunshine
2019-04-15 4:18 ` Eric Sunshine
2019-04-18 13:08 ` Johannes Schindelin
2019-04-15 14:50 ` Jeff King
2019-04-16 4:12 ` Junio C Hamano
2019-04-18 13:06 ` Johannes Schindelin
2019-04-18 16:01 ` Jeff King
2019-04-12 12:00 ` [PATCH 5/7] check-docs: do not bother checking for legacy scripts' documentation Johannes Schindelin via GitGitGadget
2019-04-15 7:19 ` Junio C Hamano
2019-04-12 12:00 ` [PATCH 6/7] test-tool: handle the `-C <directory>` option just like `git` Johannes Schindelin via GitGitGadget
2019-04-12 12:00 ` [PATCH 7/7] Turn `git serve` into a test helper Johannes Schindelin via GitGitGadget
2019-04-15 14:03 ` Junio C Hamano
2019-04-17 3:46 ` Jeff King
2019-04-17 5:40 ` Junio C Hamano
2019-04-17 18:22 ` Josh Steadmon
2019-04-18 1:58 ` Junio C Hamano
2019-04-18 12:17 ` Johannes Schindelin
2019-04-18 13:16 ` Johannes Schindelin via GitGitGadget [this message]
2019-04-18 13:16 ` [PATCH v2 1/8] remote-testgit: move it into the support directory for t5801 Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 2/8] Makefile: drop the NO_INSTALL variable Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 3/8] help -a: do not list commands that are excluded from the build Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 4/8] check-docs: allow command-list.txt to contain excluded commands Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 5/8] docs: exclude documentation for commands that have been excluded Johannes Schindelin via GitGitGadget
2019-04-19 5:20 ` Junio C Hamano
2019-04-29 12:28 ` Johannes Schindelin
2019-04-18 13:16 ` [PATCH v2 6/8] check-docs: do not bother checking for legacy scripts' documentation Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 7/8] test-tool: handle the `-C <directory>` option just like `git` Johannes Schindelin via GitGitGadget
2019-04-18 13:16 ` [PATCH v2 8/8] Turn `git serve` into a test helper Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.168.v2.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).