From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/5] Fix make check-docs on Windows
Date: Mon, 25 Mar 2019 14:41:35 -0700 (PDT) [thread overview]
Message-ID: <pull.162.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.162.git.gitgitgadget@gmail.com>
I stumbled across this when investigating one of Duy's bugs in the CI
builds.
Changes since v1:
* We no longer add an extra space in front of the $(patsubst ...) in the
second loop, but fix the underlying bug that prevented check-docs' part
from working where it discovered documented commands that are actually
not installed.
* As a fall-out, the gitremote-helpers page, which does not refer to a
command, but to a concept, was moved from section 1 to section 7.
* As a second fall-out, the documentation for git remote-testgit, which is
a command, but not installed, was removed.
* As a "while at it" patch, the part of the check-docs target that tried to
identify commands that are listed in the help, but not implemented, was
fixed to no longer mistake guides like gitattributes and gitcli for
commands.
Johannes Schindelin (5):
docs: move gitremote-helpers into section 7
docs: do not document the `git remote-testgit` command
check-docs: really look at the documented commands again
check-docs: do not expect guide pages to correspond to commands
check-docs: fix for setups where executables have an extension
Documentation/Makefile | 2 +-
Documentation/git-remote-ext.txt | 2 +-
Documentation/git-remote-fd.txt | 2 +-
Documentation/git-remote-helpers.txto | 2 +-
Documentation/git-remote-testgit.txt | 30 ---------------------------
Documentation/gitremote-helpers.txt | 4 +---
Documentation/urls.txt | 2 +-
Makefile | 7 ++++---
8 files changed, 10 insertions(+), 41 deletions(-)
delete mode 100644 Documentation/git-remote-testgit.txt
base-commit: e902e9bcae2010bc42648c80ab6adc6c5a16a4a5
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-162%2Fdscho%2Fcheck-docs-on-windows-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-162/dscho/check-docs-on-windows-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/162
Range-diff vs v1:
-: ---------- > 1: 0ad38649c0 docs: move gitremote-helpers into section 7
-: ---------- > 2: 810d2c5a94 docs: do not document the `git remote-testgit` command
-: ---------- > 3: 0dad6abd2f check-docs: really look at the documented commands again
-: ---------- > 4: 1097be7678 check-docs: do not expect guide pages to correspond to commands
1: f06126c3a1 ! 5: b26aa40c61 check-docs: fix for setups where executables have an extension
@@ -24,7 +24,7 @@
) | while read how cmd; \
do \
- case " $(ALL_COMMANDS) " in \
-+ case " $(patsubst %$X,%,$(ALL_COMMANDS)) " in \
++ case " $(patsubst %$X,%,$(ALL_COMMANDS)) " in \
*" $$cmd "*) ;; \
*) echo "removed but $$how: $$cmd" ;; \
esac; \
--
gitgitgadget
next prev parent reply other threads:[~2019-03-25 21:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 11:56 [PATCH 0/1] Fix make check-docs on Windows Johannes Schindelin via GitGitGadget
2019-03-13 11:56 ` [PATCH 1/1] check-docs: fix for setups where executables have an extension Johannes Schindelin via GitGitGadget
2019-03-14 1:54 ` Junio C Hamano
2019-03-22 18:43 ` Taylor Blau
2019-03-24 10:02 ` Johannes Schindelin
2019-03-24 12:54 ` Junio C Hamano
2019-03-25 21:08 ` Johannes Schindelin
2019-03-25 21:41 ` Johannes Schindelin via GitGitGadget [this message]
2019-03-25 21:41 ` [PATCH v2 1/5] docs: move gitremote-helpers into section 7 Johannes Schindelin via GitGitGadget
2019-03-25 21:41 ` [PATCH v2 3/5] check-docs: really look at the documented commands again Johannes Schindelin via GitGitGadget
2019-03-25 21:41 ` [PATCH v2 2/5] docs: do not document the `git remote-testgit` command Johannes Schindelin via GitGitGadget
2019-03-26 14:39 ` Ævar Arnfjörð Bjarmason
2019-03-27 22:23 ` Johannes Schindelin
2019-03-29 14:48 ` Johannes Schindelin
2019-03-25 21:41 ` [PATCH v2 4/5] check-docs: do not expect guide pages to correspond to commands Johannes Schindelin via GitGitGadget
2019-03-25 21:41 ` [PATCH v2 5/5] check-docs: fix for setups where executables have an extension Johannes Schindelin via GitGitGadget
2019-03-26 14:38 ` [PATCH v2 0/5] Fix make check-docs on Windows Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.162.v2.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).