mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Johannes Schindelin via GitGitGadget" <>
Cc: Derrick Stolee <>,
	Johannes Schindelin <>,
	Johannes Schindelin <>
Subject: [PATCH] tests(scalar): tighten the stale `scalar.repo` test some
Date: Thu, 10 Nov 2022 07:28:47 +0000	[thread overview]
Message-ID: <> (raw)

From: Johannes Schindelin <>

As pointed out by Stolee, the previous incarnation of this test case was
not stringent enough: we want to verify that _only_ the stale entries
are removed (previously, the test case would have succeeded even if all
entries had been removed).

Let's rectify this and verify that the other entries are left intact.

Signed-off-by: Johannes Schindelin <>
    tests(scalar): tighten the stale scalar.repo test some
    A follow-up for a topic already in next.

Fetch-It-Via: git fetch pr-1415/dscho/tighten-stale-scalar.repos-test-case-v1

 t/ | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/t/ b/t/
index c7f8a379108..25f500cf682 100755
--- a/t/
+++ b/t/
@@ -171,10 +171,13 @@ test_expect_success '`reconfigure -a` removes stale config entries' '
 	scalar register stale &&
 	scalar list >scalar.repos &&
 	grep stale scalar.repos &&
+	grep -v stale scalar.repos >expect &&
 	rm -rf stale &&
 	scalar reconfigure -a &&
 	scalar list >scalar.repos &&
-	! grep stale scalar.repos
+	test_cmp expect scalar.repos
 test_expect_success 'scalar delete without enlistment shows a usage' '

base-commit: c90db53d203d7ade1dc7abe63857cfb5616fe34f

             reply	other threads:[~2022-11-10  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  7:28 Johannes Schindelin via GitGitGadget [this message]
2022-11-10 13:56 ` [PATCH] tests(scalar): tighten the stale `scalar.repo` test some Derrick Stolee
2022-11-11 22:25   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).