From: "Rose via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>,
Rose <83477269+AtariDreams@users.noreply.github.com>
Subject: [PATCH v11 0/2] win32: close handles of threads that have been joined
Date: Fri, 23 Dec 2022 19:19:35 +0000 [thread overview]
Message-ID: <pull.1406.v11.git.git.1671823177.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1406.v10.git.git.1671822955.gitgitgadget@gmail.com>
After joining threads, the handle to the original thread should be closed as
it no longer needs to be open.
Signed-off-by: Seija Kijin doremylover123@gmail.com
Seija Kijin (2):
win32-pthread: prepare pthread.c for change by formatting
win32: close handles of threads that have been joined
compat/win32/pthread.c | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)
base-commit: 7c2ef319c52c4997256f5807564523dfd4acdfc7
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1406%2FAtariDreams%2Fjoin-v11
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1406/AtariDreams/join-v11
Pull-Request: https://github.com/git/git/pull/1406
Range-diff vs v10:
1: e0cc43efc6c = 1: e0cc43efc6c win32-pthread: prepare pthread.c for change by formatting
2: d05d4c2e4b2 ! 2: c5d2ddad166 win32: close handles of threads that have been joined
@@ compat/win32/pthread.c: int win32_pthread_join(pthread_t *thread, void **value_p
+ CloseHandle(thread->handle);
return EINVAL;
default:
+- return err_win_to_posix(GetLastError());
+ /* the wait failed, so do not detach */
- return err_win_to_posix(GetLastError());
++ errno = err_win_to_posix(GetLastError());
++ return errno;
}
}
+
--
gitgitgadget
next prev parent reply other threads:[~2022-12-23 19:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:34 [PATCH] win32: close handles of threads that have been joined Rose via GitGitGadget
2022-12-19 18:40 ` Ævar Arnfjörð Bjarmason
2022-12-20 7:53 ` Johannes Sixt
2022-12-20 18:57 ` [PATCH v2] " Rose via GitGitGadget
2022-12-20 19:00 ` [PATCH v3] " Rose via GitGitGadget
2022-12-20 20:03 ` [PATCH v4 0/2] " Rose via GitGitGadget
2022-12-20 20:04 ` [PATCH v4 1/2] " Seija Kijin via GitGitGadget
2022-12-20 20:04 ` [PATCH v4 2/2] prep Seija Kijin via GitGitGadget
2022-12-20 21:18 ` [PATCH v5] win32: close handles of threads that have been joined Rose via GitGitGadget
2022-12-20 22:06 ` Johannes Sixt
2022-12-21 4:35 ` [PATCH v6 0/2] " Rose via GitGitGadget
2022-12-21 4:35 ` [PATCH v6 1/2] " Seija Kijin via GitGitGadget
2022-12-21 4:35 ` [PATCH v6 2/2] prep Seija Kijin via GitGitGadget
2022-12-21 4:46 ` [PATCH v7 0/2] win32: close handles of threads that have been joined Rose via GitGitGadget
2022-12-21 4:46 ` [PATCH v7 1/2] " Seija Kijin via GitGitGadget
2022-12-22 7:52 ` Johannes Sixt
2022-12-21 4:46 ` [PATCH v7 2/2] prep Seija Kijin via GitGitGadget
2022-12-22 16:01 ` [PATCH v8] win32: close handles of threads that have been joined Rose via GitGitGadget
2022-12-22 17:17 ` [PATCH v9 0/2] " Rose via GitGitGadget
2022-12-22 17:17 ` [PATCH v9 1/2] " Seija Kijin via GitGitGadget
2022-12-22 17:17 ` [PATCH v9 2/2] prep: reformat pthread.c to fit coding guidelines Seija Kijin via GitGitGadget
2022-12-23 1:51 ` Junio C Hamano
2022-12-23 19:15 ` [PATCH v10 0/2] win32: close handles of threads that have been joined Rose via GitGitGadget
2022-12-23 19:15 ` [PATCH v10 1/2] win32-pthread: prepare pthread.c for change by formatting Seija Kijin via GitGitGadget
2022-12-23 19:15 ` [PATCH v10 2/2] win32: close handles of threads that have been joined Seija Kijin via GitGitGadget
2022-12-23 19:19 ` Rose via GitGitGadget [this message]
2022-12-23 19:19 ` [PATCH v11 1/2] win32-pthread: prepare pthread.c for change by formatting Seija Kijin via GitGitGadget
2022-12-23 19:19 ` [PATCH v11 2/2] win32: close handles of threads that have been joined Seija Kijin via GitGitGadget
2022-12-24 7:50 ` René Scharfe
2022-12-25 1:40 ` [PATCH v12 0/2] " Rose via GitGitGadget
2022-12-25 1:40 ` [PATCH v12 1/2] win32-pthread: prepare pthread.c for change by formatting Seija Kijin via GitGitGadget
2022-12-26 1:32 ` Junio C Hamano
2022-12-25 1:40 ` [PATCH v12 2/2] win32: close handles of threads that have been joined Seija Kijin via GitGitGadget
2022-12-26 2:07 ` Junio C Hamano
2023-01-03 16:20 ` [PATCH v13 0/2] " Rose via GitGitGadget
2023-01-03 16:20 ` [PATCH v13 1/2] win32: prepare pthread.c for change by formatting Seija Kijin via GitGitGadget
2023-01-03 16:20 ` [PATCH v13 2/2] win32: close handles of threads that have been joined Seija Kijin via GitGitGadget
2023-01-05 15:44 ` [PATCH v14 0/2] " Rose via GitGitGadget
2023-01-05 15:44 ` [PATCH v14 1/2] win32: prepare pthread.c for change by formatting Seija Kijin via GitGitGadget
2023-01-05 15:44 ` [PATCH v14 2/2] win32: close handles of threads that have been joined Seija Kijin via GitGitGadget
2023-01-06 12:28 ` [PATCH v14 0/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1406.v11.git.git.1671823177.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=83477269+AtariDreams@users.noreply.github.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).