From: "Rose via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Rose <83477269+AtariDreams@users.noreply.github.com>,
Seija Kijin <doremylover123@gmail.com>
Subject: [PATCH] Explicitly set errno to ENOENT if err is not ERROR_DIRECTORY
Date: Mon, 19 Dec 2022 15:51:48 +0000 [thread overview]
Message-ID: <pull.1402.git.git.1671465108414.gitgitgadget@gmail.com> (raw)
From: Seija Kijin <doremylover123@gmail.com>
At this point, the only two possible errors are
ERROR_DIRECTORY or ERROR_BAD_PATHNAME.
This code clarifies this and also saves a call to
err_win_to_posix.
Signed-off-by: Seija Kijin <doremylover123@gmail.com>
---
Explicitly set errno to ENOENT if err is not ERROR_DIRECTORY
At this point, the only two possible errors are ERROR_DIRECTORY or
ERROR_BAD_PATHNAME.
This code clarifies this and also saves a call to err_win_to_posix.
Signed-off-by: Seija Kijin doremylover123@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1402%2FAtariDreams%2Fopendir-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1402/AtariDreams/opendir-v1
Pull-Request: https://github.com/git/git/pull/1402
compat/win32/dirent.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/win32/dirent.c b/compat/win32/dirent.c
index 52420ec7d4d..8f94a5ab6db 100644
--- a/compat/win32/dirent.c
+++ b/compat/win32/dirent.c
@@ -34,13 +34,13 @@ DIR *opendir(const char *name)
if (len && !is_dir_sep(pattern[len - 1]))
pattern[len++] = '/';
pattern[len++] = '*';
- pattern[len] = 0;
+ pattern[len] = '\0';
/* open find handle */
h = FindFirstFileW(pattern, &fdata);
if (h == INVALID_HANDLE_VALUE) {
DWORD err = GetLastError();
- errno = (err == ERROR_DIRECTORY) ? ENOTDIR : err_win_to_posix(err);
+ errno = (err == ERROR_DIRECTORY) ? ENOTDIR : ENOENT;
return NULL;
}
base-commit: 7c2ef319c52c4997256f5807564523dfd4acdfc7
--
gitgitgadget
next reply other threads:[~2022-12-19 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 15:51 Rose via GitGitGadget [this message]
2022-12-19 16:20 ` [PATCH v2] win32: explicitly set errno to enoent if err is not error_directory Rose via GitGitGadget
2022-12-20 7:21 ` Johannes Sixt
2022-12-19 18:33 ` [PATCH] Explicitly set errno to ENOENT if err is not ERROR_DIRECTORY Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1402.git.git.1671465108414.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=83477269+AtariDreams@users.noreply.github.com \
--cc=doremylover123@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).