From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> To: git@vger.kernel.org Cc: Jonathan Tan <jonathantanmy@google.com>, Junio C Hamano <gitster@pobox.com> Subject: [PATCH 0/1] jt/fetch-cdn-offload: fix build with clang Date: Sun, 24 Feb 2019 14:12:10 -0800 (PST) Message-ID: <pull.139.git.gitgitgadget@gmail.com> (raw) I think this is actually legitimate a build error (see e.g. https://dev.azure.com/gitgitgadget/git/_build/results?buildId=2394), and I am quite surprised that GCC accepts this. Note: after thinking about this for a while, I guess an empty string would work, too (i.e. "" instead of " 0"), but I already waited for the macOS build to finish at https://github.com/gitgitgadget/git/pull/139, and it's a fixup! for Jonathan to pick up, anyway... Junio, could I ask you to apply this on top of your SQUASH??? to fix the build? Johannes Schindelin (1): fixup! upload-pack: refactor reading of pack-objects out upload-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 2c31d711669adc7a7bfad06df37b976af99dfaa6 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-139%2Fdscho%2Fjt%2Ffetch-cdn-offload-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-139/dscho/jt/fetch-cdn-offload-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/139 -- gitgitgadget
next reply other threads:[~2019-02-24 22:12 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-24 22:12 Johannes Schindelin via GitGitGadget [this message] 2019-02-24 22:12 ` [PATCH 1/1] fixup! upload-pack: refactor reading of pack-objects out Johannes Schindelin via GitGitGadget 2019-03-03 1:21 ` Junio C Hamano 2019-03-03 15:01 ` Johannes Schindelin 2019-03-11 12:54 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=pull.139.git.gitgitgadget@gmail.com \ --to=gitgitgadget@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=jonathantanmy@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git