mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Simon Gerber via GitGitGadget" <>
Cc: Simon Gerber <>
Subject: [PATCH 0/2] Fix autocorrect in work tree for bare repository
Date: Fri, 28 Oct 2022 15:24:03 +0000	[thread overview]
Message-ID: <> (raw)

Currently, auto correction doesn't work reliably for commands which must run
in a work tree (e.g. git status) in Git work trees which are created from a
bare repository.

This patch series adds a test case illustrating the issue and proposes a fix
which adjusts the usage of read_early_config() in help_unknown_cmd() to
match other usages of read_early_config(). In particular the patch removes
the call to git_default_config() in the read config callback.

Simon Gerber (2):
  tests: add test case for autocorrect in work tree for bare clone
  help.c: don't call git_default_config in git_unknown_cmd_config

 help.c                               |  2 +-
 t/ | 29 ++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100755 t/

base-commit: e7e5c6f715b2de7bea0d39c7d2ba887335b40aa0
Fetch-It-Via: git fetch pr-git-1373/simu/fix/autocorrect-bare-worktree-v1

             reply	other threads:[~2022-10-28 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 15:24 Simon Gerber via GitGitGadget [this message]
2022-10-28 15:24 ` [PATCH 1/2] tests: add test case for autocorrect in work tree for bare clone Simon Gerber via GitGitGadget
2022-10-28 19:28   ` Junio C Hamano
2022-10-29  8:07     ` Simon Gerber
2022-10-28 15:24 ` [PATCH 2/2] help.c: don't call git_default_config in git_unknown_cmd_config Simon Gerber via GitGitGadget
2022-10-29 19:56 ` [PATCH v2] help.c: fix autocorrect in work tree for bare repository Simon Gerber via GitGitGadget
2022-12-12 16:38   ` Simon Gerber
2022-12-13  1:37   ` Junio C Hamano
2022-12-13  9:48     ` Simon Gerber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).