* [PATCH] setup: fix function name
@ 2022-06-09 13:55 Cleber Rosa via GitGitGadget
2022-06-17 22:43 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Cleber Rosa via GitGitGadget @ 2022-06-09 13:55 UTC (permalink / raw)
To: git; +Cc: Cleber Rosa, Cleber Rosa
From: Cleber Rosa <crosa@redhat.com>
The reference given to users when the result of
setup_git_directory_gently_1() is unexpected is incorrect.
This fixes the name of the function when presenting the BUG message.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
setup: fix function name
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1255%2Fclebergnu%2Ffix_function_name-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1255/clebergnu/fix_function_name-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1255
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index faf5095e44d..b5a537258d2 100644
--- a/setup.c
+++ b/setup.c
@@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
* find a repository.
*/
default:
- BUG("unhandled setup_git_directory_1() result");
+ BUG("unhandled setup_git_directory_gently_1() result");
}
/*
base-commit: 9c897eef06347cc5a3eb07c3ae409970ab1052c8
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] setup: fix function name
2022-06-09 13:55 [PATCH] setup: fix function name Cleber Rosa via GitGitGadget
@ 2022-06-17 22:43 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2022-06-17 22:43 UTC (permalink / raw)
To: Cleber Rosa via GitGitGadget; +Cc: git, Cleber Rosa
"Cleber Rosa via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Cleber Rosa <crosa@redhat.com>
> Subject: Re: [PATCH] setup: fix function name
I'd add "in a BUG() message" at the end.
> diff --git a/setup.c b/setup.c
> index faf5095e44d..b5a537258d2 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
> * find a repository.
> */
> default:
> - BUG("unhandled setup_git_directory_1() result");
> + BUG("unhandled setup_git_directory_gently_1() result");
> }
Did you actually hit this BUG() and was sent to a wild goose chase
because of this typo? Just checking, because BUG() that triggers
is a more serious issue itself.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-17 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 13:55 [PATCH] setup: fix function name Cleber Rosa via GitGitGadget
2022-06-17 22:43 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).