From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> To: git@vger.kernel.org Cc: gitster@pobox.com, me@ttaylorr.com, johannes.schindelin@gmx.de, Derrick Stolee <derrickstolee@github.com> Subject: [PATCH 0/3] Updates to the safe.directory config option Date: Wed, 13 Apr 2022 15:32:28 +0000 [thread overview] Message-ID: <pull.1215.git.1649863951.gitgitgadget@gmail.com> (raw) Here is a very fast response to the security release yesterday. The second patch here is an adaptation from a contributor who created a pull request against git/git [1]. I augmented the patch with a test (the test infrastructure is added in patch 1). The third patch is a change to the safe.directory config option to include a possible "*" value to completely opt-out of the check. This will be particularly helpful for cases where users run Git commands within a container. This container workflow always runs as a different user than the host, but also the container does not have access to the host's system or global config files. It's also helpful for users who don't want to set the config for a large number of shared repositories [2]. Thanks, -Stolee [1] https://github.com/git/git/pull/1235 [2] https://github.com/git-for-windows/git/issues/3787 [3] https://github.com/desktop/desktop/issues/14336 Derrick Stolee (2): t0033: add tests for safe.directory setup: opt-out of check with safe.directory=* Matheus Valadares (1): setup: fix safe.directory key not being checked Documentation/config/safe.txt | 7 +++++ setup.c | 12 ++++++--- t/t0033-safe-directory.sh | 49 +++++++++++++++++++++++++++++++++++ 3 files changed, 65 insertions(+), 3 deletions(-) create mode 100755 t/t0033-safe-directory.sh base-commit: 11cfe552610386954886543f5de87dcc49ad5735 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1215%2Fderrickstolee%2Fsafe-directories-star-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1215/derrickstolee/safe-directories-star-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1215 -- gitgitgadget
next reply other threads:[~2022-04-13 15:32 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-13 15:32 Derrick Stolee via GitGitGadget [this message] 2022-04-13 15:32 ` [PATCH 1/3] t0033: add tests for safe.directory Derrick Stolee via GitGitGadget 2022-04-13 16:24 ` Junio C Hamano 2022-04-13 16:29 ` Derrick Stolee 2022-04-13 19:16 ` Ævar Arnfjörð Bjarmason 2022-04-13 19:46 ` Junio C Hamano 2022-04-13 19:52 ` Derrick Stolee 2022-04-13 15:32 ` [PATCH 2/3] setup: fix safe.directory key not being checked Matheus Valadares via GitGitGadget 2022-04-13 16:34 ` Junio C Hamano 2022-04-13 15:32 ` [PATCH 3/3] setup: opt-out of check with safe.directory=* Derrick Stolee via GitGitGadget 2022-04-13 16:40 ` Junio C Hamano 2022-04-13 16:15 ` [PATCH 0/3] Updates to the safe.directory config option Junio C Hamano 2022-04-13 16:25 ` Derrick Stolee 2022-04-13 16:44 ` Junio C Hamano 2022-04-13 20:27 ` Junio C Hamano 2022-04-13 21:25 ` Taylor Blau 2022-04-13 21:45 ` Junio C Hamano 2022-04-27 17:06 ` [PATCH 0/3] t0033-safe-directory: test improvements and a documentation clarification SZEDER Gábor 2022-04-27 17:06 ` [PATCH 1/3] t0033-safe-directory: check the error message without matching the trash dir SZEDER Gábor 2022-05-09 22:27 ` Taylor Blau 2022-05-10 6:04 ` Carlo Marcelo Arenas Belón 2022-04-27 17:06 ` [PATCH 2/3] t0033-safe-directory: check when 'safe.directory' is ignored SZEDER Gábor 2022-04-27 20:37 ` Junio C Hamano 2022-04-29 16:12 ` Derrick Stolee 2022-04-29 17:57 ` Junio C Hamano 2022-04-29 19:06 ` SZEDER Gábor 2022-04-29 19:19 ` Derrick Stolee 2022-05-10 18:33 ` SZEDER Gábor 2022-05-10 19:55 ` Taylor Blau 2022-05-10 20:06 ` Carlo Marcelo Arenas Belón 2022-05-10 20:11 ` Taylor Blau 2022-05-10 20:18 ` Eric Sunshine 2022-04-27 17:06 ` [PATCH 3/3] safe.directory: document and check that it's ignored in the environment SZEDER Gábor 2022-04-27 20:42 ` Junio C Hamano 2022-04-27 20:49 ` Junio C Hamano 2022-04-29 16:13 ` Derrick Stolee 2022-05-09 21:39 ` SZEDER Gábor 2022-05-09 21:45 ` Junio C Hamano 2022-05-10 18:48 ` SZEDER Gábor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=pull.1215.git.1649863951.gitgitgadget@gmail.com \ --to=gitgitgadget@gmail.com \ --cc=derrickstolee@github.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=johannes.schindelin@gmx.de \ --cc=me@ttaylorr.com \ --subject='Re: [PATCH 0/3] Updates to the safe.directory config option' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).