From: "Labnan via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Labnan <khalid.masum.92@gmail.com>, Labnann <khalid.masum.92@gmail.com>
Subject: [PATCH] t3501: use test_path_is_* functions
Date: Wed, 30 Mar 2022 21:43:05 +0000 [thread overview]
Message-ID: <pull.1195.git.1648676585765.gitgitgadget@gmail.com> (raw)
From: Labnann <khalid.masum.92@gmail.com>
Two test -f are present in t3501. They can be replaced with appropriate
helper function: test_path_is_file
Signed-off-by: Labnann <khalid.masum.92@gmail.com>
---
[GSoC][PATCH] t3501: Use test_path_is_* Functions
Two test -f are present in t3501. They can be replaced with appropriate
helper function: test_path_is_file. Which makes the script more readable
and gives better error messages.
Signed-off-by: Labnann khalid.masum.92@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1195%2FLabnann%2Ft3501-helper-functions-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1195/Labnann/t3501-helper-functions-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1195
t/t3501-revert-cherry-pick.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3501-revert-cherry-pick.sh b/t/t3501-revert-cherry-pick.sh
index 8617efaaf1e..45492a7ed09 100755
--- a/t/t3501-revert-cherry-pick.sh
+++ b/t/t3501-revert-cherry-pick.sh
@@ -67,7 +67,7 @@ test_expect_success 'cherry-pick after renaming branch' '
git checkout rename2 &&
git cherry-pick added &&
test $(git rev-parse HEAD^) = $(git rev-parse rename2) &&
- test -f opos &&
+ test_path_is_file opos &&
grep "Add extra line at the end" opos &&
git reflog -1 | grep cherry-pick
@@ -78,7 +78,7 @@ test_expect_success 'revert after renaming branch' '
git checkout rename1 &&
git revert added &&
test $(git rev-parse HEAD^) = $(git rev-parse rename1) &&
- test -f spoo &&
+ test_path_is_file spoo &&
! grep "Add extra line at the end" spoo &&
git reflog -1 | grep revert
base-commit: 805e0a68082a217f0112db9ee86a022227a9c81b
--
gitgitgadget
next reply other threads:[~2022-03-30 21:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 21:43 Labnan via GitGitGadget [this message]
2022-03-30 22:11 ` [PATCH] t3501: use test_path_is_* functions Ævar Arnfjörð Bjarmason
2022-03-31 19:15 ` [PATCH v2 0/3][GSoC] t3501: remove test and test -f Labnann
2022-03-31 19:15 ` [PATCH v2 1/3] t3501: use test_path_is_* functions Labnann
2022-03-31 19:15 ` [PATCH v2 2/3] t3501: don't ignore "git <cmd>" exit code Labnann
2022-04-01 18:10 ` Junio C Hamano
2022-03-31 19:15 ` [PATCH v2 3/3] t3501: test cherry-pick revert with oids Labnann
2022-04-01 18:24 ` Junio C Hamano
2022-04-02 19:24 ` [PATCH v3 0/1][GSoC] t3501: remove redundant file checking and stop ignoring git <cmd> exit code Labnann
2022-04-02 19:24 ` [PATCH v3 1/1] t3501: remove redundant file check " Labnann
2022-04-04 15:54 ` Junio C Hamano
2022-04-05 13:47 ` [PATCH v4 0/1][GSoC] t3501: remove test -f " Khalid Masum
2022-04-05 13:47 ` [PATCH v4 1/1] " Khalid Masum
2022-04-05 15:06 ` [PATCH v4 0/1][GSoC] " Khalid Masum
2022-04-05 15:06 ` [PATCH v4 1/1] " Khalid Masum
2022-04-22 11:26 ` [PATCH v2] " Labnan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1195.git.1648676585765.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=khalid.masum.92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).