From: "Neeraj K. Singh via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Neeraj K. Singh" <neerajsi@microsoft.com>,
Neeraj Singh <neerajsi@microsoft.com>
Subject: [PATCH] core.fsync: fix incorrect expression for default configuration
Date: Tue, 29 Mar 2022 21:41:52 +0000 [thread overview]
Message-ID: <pull.1191.git.1648590113062.gitgitgadget@gmail.com> (raw)
From: Neeraj Singh <neerajsi@microsoft.com>
Commit b9f5d0358d2e882 introduced an incorrect value for
FSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than
OR-NOT.
Signed-off-by: Neeraj Singh <neerajsi@microsoft.com>
---
core.fsync: fix incorrect expression for default configuration
Commit b9f5d0358d2e882 introduced an incorrect value for
FSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than OR-NOT.
Signed-off-by: Neeraj Singh neerajsi@microsoft.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1191%2Fneerajsi-msft%2Fns%2Ffix-fsync-default-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1191/neerajsi-msft/ns/fix-fsync-default-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1191
cache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cache.h b/cache.h
index ef7d34b7a09..ee9549c4601 100644
--- a/cache.h
+++ b/cache.h
@@ -1014,8 +1014,8 @@ enum fsync_component {
#define FSYNC_COMPONENTS_DERIVED_METADATA (FSYNC_COMPONENT_PACK_METADATA | \
FSYNC_COMPONENT_COMMIT_GRAPH)
-#define FSYNC_COMPONENTS_DEFAULT (FSYNC_COMPONENTS_OBJECTS | \
- FSYNC_COMPONENTS_DERIVED_METADATA | \
+#define FSYNC_COMPONENTS_DEFAULT ((FSYNC_COMPONENTS_OBJECTS | \
+ FSYNC_COMPONENTS_DERIVED_METADATA) & \
~FSYNC_COMPONENT_LOOSE_OBJECT)
#define FSYNC_COMPONENTS_COMMITTED (FSYNC_COMPONENTS_OBJECTS | \
base-commit: 1d4f13e63720fb8eae39afa215199f7d77662dba
--
gitgitgadget
reply other threads:[~2022-03-29 21:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1191.git.1648590113062.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=neerajsi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).