From: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Han-Wen Nienhuys <hanwen@google.com>,
Han-Wen Nienhuys <hanwenn@gmail.com>
Subject: [PATCH v2 0/3] refs: cleanup errno sideband ref related functions.
Date: Fri, 23 Apr 2021 15:31:44 +0000 [thread overview]
Message-ID: <pull.1011.v2.git.git.1619191907.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1011.git.git.1619173446857.gitgitgadget@gmail.com>
v2:
* peff's feedback. For now, leave refs.c alone; instead cleanups in
files-backend and the ref backend API.
Han-Wen Nienhuys (3):
refs: remove EINVAL specification from the errno sideband in
read_raw_ref_fn
refs/files-backend: stop setting errno from lock_ref_oid_basic
refs: make errno output explicit for read_raw_ref_fn
refs.c | 7 +++++--
refs/debug.c | 4 ++--
refs/files-backend.c | 26 +++++++++-----------------
refs/packed-backend.c | 5 +++--
refs/refs-internal.h | 14 ++++++++------
5 files changed, 27 insertions(+), 29 deletions(-)
base-commit: 311531c9de557d25ac087c1637818bd2aad6eb3a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1011%2Fhanwen%2Feinval-sideband-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1011/hanwen/einval-sideband-v2
Pull-Request: https://github.com/git/git/pull/1011
Range-diff vs v1:
1: ed080f6a9c40 ! 1: 7e8181e77d40 refs: remove EINVAL specification from the errno sideband in read_raw_ref_fn
@@ Commit message
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
- ## refs.c ##
-@@ refs.c: const char *refs_resolve_ref_unsafe(struct ref_store *refs,
- if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
- if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
- !refname_is_safe(refname)) {
-- errno = EINVAL;
- return NULL;
- }
-
-@@ refs.c: const char *refs_resolve_ref_unsafe(struct ref_store *refs,
- if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
- if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
- !refname_is_safe(refname)) {
-- errno = EINVAL;
- return NULL;
- }
-
-
## refs/refs-internal.h ##
@@ refs/refs-internal.h: typedef int reflog_expire_fn(struct ref_store *ref_store,
* properly-formatted or even safe reference name. NEITHER INPUT NOR
-: ------------ > 2: db5da7d7fb51 refs/files-backend: stop setting errno from lock_ref_oid_basic
-: ------------ > 3: 7fbc1c754f43 refs: make errno output explicit for read_raw_ref_fn
--
gitgitgadget
next prev parent reply other threads:[~2021-04-23 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 10:24 [PATCH] refs: remove EINVAL specification from the errno sideband in read_raw_ref_fn Han-Wen Nienhuys via GitGitGadget
2021-04-23 12:57 ` Jeff King
2021-04-23 15:25 ` Han-Wen Nienhuys
2021-04-23 15:31 ` Han-Wen Nienhuys via GitGitGadget [this message]
2021-04-23 15:31 ` [PATCH v2 1/3] " Han-Wen Nienhuys via GitGitGadget
2021-04-23 15:31 ` [PATCH v2 2/3] refs/files-backend: stop setting errno from lock_ref_oid_basic Han-Wen Nienhuys via GitGitGadget
2021-04-28 4:20 ` Junio C Hamano
2021-04-28 10:55 ` Han-Wen Nienhuys
2021-04-29 1:55 ` Junio C Hamano
2021-04-29 8:52 ` Han-Wen Nienhuys
2021-04-23 15:31 ` [PATCH v2 3/3] refs: make errno output explicit for read_raw_ref_fn Han-Wen Nienhuys via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1011.v2.git.git.1619191907.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).