git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Elijah Newren" <newren@gmail.com>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"Andrzej Hunt" <ajrhunt@google.com>, "Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 9/9] leak tests: mark some misc tests as passing with SANITIZE=leak
Date: Tue, 12 Oct 2021 15:56:45 +0200	[thread overview]
Message-ID: <patch-v2-9.9-ba30265cb72-20211012T135343Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-v2-0.9-00000000000-20211012T135343Z-avarab@gmail.com>

Mark some tests that match "*{mktree,commit,diff,grep,rm,merge,hunk}*"
as passing when git is compiled with SANITIZE=leak. They'll now be
listed as running under the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test
mode (the "linux-leaks" CI target).

These were picked because we still have a lot of failures in adjacent
areas, and we didn't have much if any coverage of e.g. grep and diff
before this change, we could still whitelist a lot more tests, but
let's stop for now.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t1010-mktree.sh              | 1 +
 t/t1100-commit-tree-options.sh | 1 +
 t/t3601-rm-pathspec-file.sh    | 1 +
 t/t4002-diff-basic.sh          | 2 ++
 t/t4016-diff-quote.sh          | 1 +
 t/t4019-diff-wserror.sh        | 1 +
 t/t4025-hunk-header.sh         | 1 +
 t/t4300-merge-tree.sh          | 2 ++
 t/t7813-grep-icase-iso.sh      | 1 +
 t/t7816-grep-binary-pattern.sh | 1 +
 10 files changed, 12 insertions(+)

diff --git a/t/t1010-mktree.sh b/t/t1010-mktree.sh
index b946f876864..48bfad07abc 100755
--- a/t/t1010-mktree.sh
+++ b/t/t1010-mktree.sh
@@ -2,6 +2,7 @@
 
 test_description='git mktree'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '
diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
index ae66ba5babf..0f37a43fd3c 100755
--- a/t/t1100-commit-tree-options.sh
+++ b/t/t1100-commit-tree-options.sh
@@ -12,6 +12,7 @@ Also make sure that command line parser understands the normal
 "flags first and then non flag arguments" command line.
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 cat >expected <<EOF
diff --git a/t/t3601-rm-pathspec-file.sh b/t/t3601-rm-pathspec-file.sh
index 7de21f8bcff..b2a8db69afc 100755
--- a/t/t3601-rm-pathspec-file.sh
+++ b/t/t3601-rm-pathspec-file.sh
@@ -2,6 +2,7 @@
 
 test_description='rm --pathspec-from-file'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_tick
diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
index 6a9f010197c..ea52e5b91b7 100755
--- a/t/t4002-diff-basic.sh
+++ b/t/t4002-diff-basic.sh
@@ -6,6 +6,8 @@
 test_description='Test diff raw-output.
 
 '
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 . "$TEST_DIRECTORY"/lib-read-tree-m-3way.sh
diff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh
index 876271d6826..5a8d8876831 100755
--- a/t/t4016-diff-quote.sh
+++ b/t/t4016-diff-quote.sh
@@ -6,6 +6,7 @@
 test_description='Quoting paths in diff output.
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 P0='pathname'
diff --git a/t/t4019-diff-wserror.sh b/t/t4019-diff-wserror.sh
index c6135c75488..c68729ac098 100755
--- a/t/t4019-diff-wserror.sh
+++ b/t/t4019-diff-wserror.sh
@@ -2,6 +2,7 @@
 
 test_description='diff whitespace error detection'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '
diff --git a/t/t4025-hunk-header.sh b/t/t4025-hunk-header.sh
index 35578f2bb91..6356961de46 100755
--- a/t/t4025-hunk-header.sh
+++ b/t/t4025-hunk-header.sh
@@ -2,6 +2,7 @@
 
 test_description='diff hunk header truncation'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 N='日本語'
diff --git a/t/t4300-merge-tree.sh b/t/t4300-merge-tree.sh
index e59601e5fe9..c52c8a21fae 100755
--- a/t/t4300-merge-tree.sh
+++ b/t/t4300-merge-tree.sh
@@ -4,6 +4,8 @@
 #
 
 test_description='git merge-tree'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '
diff --git a/t/t7813-grep-icase-iso.sh b/t/t7813-grep-icase-iso.sh
index 701e08a8e59..1227885737b 100755
--- a/t/t7813-grep-icase-iso.sh
+++ b/t/t7813-grep-icase-iso.sh
@@ -2,6 +2,7 @@
 
 test_description='grep icase on non-English locales'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-gettext.sh
 
 test_expect_success GETTEXT_ISO_LOCALE 'setup' '
diff --git a/t/t7816-grep-binary-pattern.sh b/t/t7816-grep-binary-pattern.sh
index 9d67a5fc4cf..fdb2355649e 100755
--- a/t/t7816-grep-binary-pattern.sh
+++ b/t/t7816-grep-binary-pattern.sh
@@ -2,6 +2,7 @@
 
 test_description='git grep with a binary pattern files'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-gettext.sh
 
 nul_match_internal () {
-- 
2.33.0.1567.g7b23ce7ed9e


      parent reply	other threads:[~2021-10-12 13:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  9:50 [PATCH 00/10] leak tests: mark more tests as passing Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 01/10] leak tests: run various built-in tests in t00*.sh SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-07 22:33   ` Junio C Hamano
2021-10-06  9:50 ` [PATCH 02/10] leak tests: run various "test-tool" " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 03/10] leak tests: mark t0000-init.sh as passing with SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-07 22:35   ` Junio C Hamano
2021-10-12 13:39     ` Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 04/10] leak tests: mark all ls-tree tests " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 05/10] leak tests: mark all trace2 " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 06/10] leak tests: mark all checkout-index " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 07/10] leak tests: mark some ls-files " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 08/10] leak tests: mark some read-tree " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 09/10] leak tests: mark various "generic" " Ævar Arnfjörð Bjarmason
2021-10-06  9:50 ` [PATCH 10/10] leak tests: mark some misc " Ævar Arnfjörð Bjarmason
2021-10-06 16:26 ` [PATCH 00/10] leak tests: mark more tests as passing Elijah Newren
2021-10-07 22:38   ` Junio C Hamano
2021-10-12 13:40   ` Ævar Arnfjörð Bjarmason
2021-10-12 13:56 ` [PATCH v2 0/9] " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 1/9] leak tests: run various built-in tests in t00*.sh SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 2/9] leak tests: run various "test-tool" " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 3/9] leak tests: mark all ls-tree tests as passing with SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 4/9] leak tests: mark all trace2 " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 5/9] leak tests: mark all checkout-index " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 6/9] leak tests: mark some ls-files " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 7/9] leak tests: mark some read-tree " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` [PATCH v2 8/9] leak tests: mark various "generic" " Ævar Arnfjörð Bjarmason
2021-10-12 13:56   ` Ævar Arnfjörð Bjarmason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patch-v2-9.9-ba30265cb72-20211012T135343Z-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=ajrhunt@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).