From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C351F1F670 for ; Sat, 16 Oct 2021 09:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244042AbhJPJmn (ORCPT ); Sat, 16 Oct 2021 05:42:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243957AbhJPJlw (ORCPT ); Sat, 16 Oct 2021 05:41:52 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33921C0613F0 for ; Sat, 16 Oct 2021 02:39:39 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id g2so4274904wme.4 for ; Sat, 16 Oct 2021 02:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a+/GYTZZy8e5Kz/F593qTISxA5IriUQJ0TZs3Z7GU3w=; b=pPIuA0ZgEnNNoVvPmOv8E8bYcY1S1nITu3u3CMMySWGV/6I4UTrVuUZF/ik7AEsjsF SWmhV3XlINADn6CAk2bVM6uGMyCiCTKNwFz42TeX+GFpNXIRupQ7Hsi7cXyr7MgO0oaA 5IwKULhNBPdbpOV/cd/DV4fAG7xgkGDbBEWc960a1jpoy098Qn4RbKvGJI0szmyo1Svo bKKsXDBXpCwDmRAO5+hInphUDwoNum+DnJ4xhkGFHDdpyANWxcXwa8kRABIm/8PfZ165 RcPvqk11siQr85fsosk0lHQZaA+IbWXNdf9c2cp6Ko48edsFRofTmQ7C2hb7WNnlpD7/ LAYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+/GYTZZy8e5Kz/F593qTISxA5IriUQJ0TZs3Z7GU3w=; b=moGsTYzhfboBkLvt5fnqz+WzUlao36/RfBJrYRT0j4wKCfEfZ9uZQS3NMoJuc+hi6t IxRMQEpOPoe7FgwgU4N4ThHE53VpK+0V/iQ43sVLbiYmNr8I6kuGsjILQVr1P5s+f1tC rPllxtPGTmMIiv5HBU2FLh+ZxbfhFDB9aWIj4Q85CkDPbHt90dtQePjCWDlLkud7ZWwF imTBGG1xvjR1IZU2DdyhYCOhtD2lKCSl8oR51F6WS+vQzruw9NJ5SlWsotF0PAA9uPDC J14/Uw3Vt7UDeKZDwNA7XXmhJuoDRo+wcvBObKkclzOxgIq5H9aFdoi3zgXNgfjZ648N 7nTw== X-Gm-Message-State: AOAM533jTjJHhHf7PHWx6QT1OeE+ctcf+i6Ex9urEYnaieQLp9nL+wXX 3i+JNesqAYslUa6hWMXukaF3pNi7n4sSPg== X-Google-Smtp-Source: ABdhPJyV2vD/qv0qaNbuwOljb6T7tvbbGyCBhJ8naIgL36C4+nYdZe9o7orZn69y0ixSeiVRfyS1KQ== X-Received: by 2002:a1c:e906:: with SMTP id q6mr31921385wmc.126.1634377177604; Sat, 16 Oct 2021 02:39:37 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id k22sm6993492wrd.59.2021.10.16.02.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Oct 2021 02:39:37 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Han-Wen Nienhuys , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v2 10/21] refs API: make loose_fill_ref_dir() not set errno Date: Sat, 16 Oct 2021 11:39:16 +0200 Message-Id: X-Mailer: git-send-email 2.33.1.1338.g20da966911a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change the refs_resolve_ref_unsafe() invoked in loose_fill_ref_dir() to a form that ignores errno. The only eventual caller of this function is create_ref_cache(), whose callers in turn don't have their failure depend on any errno set here. Signed-off-by: Ævar Arnfjörð Bjarmason --- refs/files-backend.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/refs/files-backend.c b/refs/files-backend.c index 482d04de03a..759c21e88ae 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -280,10 +280,11 @@ static void loose_fill_ref_dir(struct ref_store *ref_store, create_dir_entry(dir->cache, refname.buf, refname.len)); } else { - if (!refs_resolve_ref_unsafe(&refs->base, + int ignore_errno; + if (!refs_werrres_ref_unsafe(&refs->base, refname.buf, RESOLVE_REF_READING, - &oid, &flag)) { + &oid, &flag, &ignore_errno)) { oidclr(&oid); flag |= REF_ISBROKEN; } else if (is_null_oid(&oid)) { -- 2.33.1.1338.g20da966911a