From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Victoria Dye" <vdye@github.com>, "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2] CI: migrate away from deprecated "set-output" syntax
Date: Wed, 7 Dec 2022 02:49:18 +0100 [thread overview]
Message-ID: <patch-v2-1.1-4e7db0db3be-20221207T014848Z-avarab@gmail.com> (raw)
In-Reply-To: <patch-1.1-deb65805345-20221206T195811Z-avarab@gmail.com>
As noted in [1] and the warnings the CI itself is spewing echoing
outputs to stdout is deprecated, and they should be written to
"$GITHUB_OUTPUT" instead.
1. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
Range-diff against v1:
1: deb65805345 ! 1: 4e7db0db3be CI: migrate away from deprecated "set-output" syntax
@@ Commit message
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
+ ## .github/workflows/l10n.yml ##
+@@ .github/workflows/l10n.yml: jobs:
+ base=${{ github.event.before }}
+ head=${{ github.event.after }}
+ fi
+- echo "::set-output name=base::$base"
+- echo "::set-output name=head::$head"
++ cat >>$GITHUB_OUTPUT <<-EOF
++ base=$base
++ head=$head
++ EOF
+ - name: Run partial clone
+ run: |
+ git -c init.defaultBranch=master init --bare .
+
## .github/workflows/main.yml ##
@@ .github/workflows/main.yml: jobs:
then
.github/workflows/l10n.yml | 6 ++++--
.github/workflows/main.yml | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/l10n.yml b/.github/workflows/l10n.yml
index 27f72f0ff34..8fa073db2dc 100644
--- a/.github/workflows/l10n.yml
+++ b/.github/workflows/l10n.yml
@@ -23,8 +23,10 @@ jobs:
base=${{ github.event.before }}
head=${{ github.event.after }}
fi
- echo "::set-output name=base::$base"
- echo "::set-output name=head::$head"
+ cat >>$GITHUB_OUTPUT <<-EOF
+ base=$base
+ head=$head
+ EOF
- name: Run partial clone
run: |
git -c init.defaultBranch=master init --bare .
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 9afacfa0b33..d1e16009b11 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -34,7 +34,7 @@ jobs:
then
enabled=no
fi
- echo "::set-output name=enabled::$enabled"
+ echo "enabled=$enabled" >>$GITHUB_OUTPUT
- name: skip if the commit or tree was already tested
id: skip-if-redundant
uses: actions/github-script@v6
--
2.39.0.rc2.1019.gce04d262ea9
next prev parent reply other threads:[~2022-12-07 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 20:00 [PATCH] CI: migrate away from deprecated "set-output" syntax Ævar Arnfjörð Bjarmason
2022-12-06 20:50 ` Victoria Dye
2022-12-06 21:08 ` Ævar Arnfjörð Bjarmason
2022-12-07 0:56 ` Taylor Blau
2022-12-07 1:49 ` Ævar Arnfjörð Bjarmason [this message]
2022-12-07 23:57 ` [PATCH v2] " Junio C Hamano
2022-12-08 0:27 ` Ævar Arnfjörð Bjarmason
2022-12-08 5:41 ` Junio C Hamano
2022-12-08 0:33 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patch-v2-1.1-4e7db0db3be-20221207T014848Z-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).