From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6EA2A1F601 for ; Wed, 20 Jul 2022 21:22:16 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="I2+kp1IT"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230397AbiGTVWH (ORCPT ); Wed, 20 Jul 2022 17:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiGTVWG (ORCPT ); Wed, 20 Jul 2022 17:22:06 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDCF4D4EB for ; Wed, 20 Jul 2022 14:22:05 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id n185so11627975wmn.4 for ; Wed, 20 Jul 2022 14:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ClugNw9CmOqcvFZ7SKznLsqRvjuPtXXfdpbbOzXfJlo=; b=I2+kp1ITJKCrgLfbcU0QtzGvs+fKLh8ratZg3PWaeiliGetKauXGnuRUXHMAQibpEZ NgkKDlp/UeKzVQcMBNBG+MYdeHiWtAEU7F4DM5tpEr2lp13sEaeNWnpYV7TRpP99NGkP r8fKna9XodK/CDayok7RNdzEEja44k9kcXT6hbSTRKtKqr30UQpAp4tFjnqin7JX685i Ze9WL9Tu/T/k5jB8XX0+w+Qf+i0kuYvJrxhjQtb/kijIw8FbZc/zmEo1Z2rOVmdKzGKv O50n5E4Ln52lYo+nMGJXR/WyaXVNBvUGHQXCuae99i3Ogf4PwLlMBcKzwQ6xAaVZbHW5 j6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ClugNw9CmOqcvFZ7SKznLsqRvjuPtXXfdpbbOzXfJlo=; b=aqGoQOCqvXrEgf64i8San3CjdhQBFN2bV1VrPTQPbsAOw8EFlcKdX5GjARjVbByrm7 zzP9qyYiPY/bpwDQH8TIWKJGk87AyWwsgOGHgXGpAZ0VVozksMphoeyk04ZxuOt4TDLc V3O5UbU2zrI+NWEfrUqOjTkb7pSCBHeK/3teiLtfV+8oDPqGnhHSflxSpbNd1UHWugCJ SWGRT2nLXGUERqZ81XbKlbxIL1KS+WCLjGklHb+6fLn6lLomNCrBkTiu2pS+D4pa3hkN lPdp9jHgQK3POkkvhoq07GUnFjWPXK5Nri3LHxqXEGM88xt+xuXCfEgDmua5fYKw24LG pMsg== X-Gm-Message-State: AJIora9MP7QiMkUt+vOaW7nDI9EchkxDNEwEJerHtXQXYbpOZdjFavTT FIIPBThlduUUKK+k3/b6nOw5kYzDPNbalg== X-Google-Smtp-Source: AGRyM1uyz29KgLhLzb1CrKAD4IKqSow4tBXt4cqrvEzYDvRYjOnIqXhFCYJz09R4JrDnkgSkcWtMnw== X-Received: by 2002:a1c:cc15:0:b0:3a3:a03:588 with SMTP id h21-20020a1ccc15000000b003a30a030588mr5656495wmb.29.1658352123767; Wed, 20 Jul 2022 14:22:03 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c024800b003a0375c4f73sm3605441wmj.44.2022.07.20.14.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 14:22:02 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Derrick Stolee , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v2 01/14] test-lib: use $1, not $@ in test_known_broken_{ok,failure}_ Date: Wed, 20 Jul 2022 23:21:39 +0200 Message-Id: X-Mailer: git-send-email 2.37.1.1064.gc96144cf387 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Clarify that these two functions never take N arguments, they'll only ever receive one. They've needlessly used $@ over $1 since 41ac414ea2b (Sane use of test_expect_failure, 2008-02-01). In the future we might want to pass the test source to these, but now that's not the case. This preparatory change helps to clarify a follow-up change. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/test-lib.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 7726d1da88a..3f11ce35112 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -804,14 +804,14 @@ test_failure_ () { test_known_broken_ok_ () { test_fixed=$(($test_fixed+1)) - say_color error "ok $test_count - $@ # TODO known breakage vanished" - finalize_test_case_output fixed "$@" + say_color error "ok $test_count - $1 # TODO known breakage vanished" + finalize_test_case_output fixed "$1" } test_known_broken_failure_ () { test_broken=$(($test_broken+1)) - say_color warn "not ok $test_count - $@ # TODO known breakage" - finalize_test_case_output broken "$@" + say_color warn "not ok $test_count - $1 # TODO known breakage" + finalize_test_case_output broken "$1" } test_debug () { -- 2.37.1.1064.gc96144cf387