From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Elijah Newren" <newren@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 4/4] read-cache perf: add a perf test for refresh_index()
Date: Mon, 7 Jun 2021 13:58:27 +0200 [thread overview]
Message-ID: <patch-4.4-120a37acae-20210607T115454Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-0.4-0000000000-20210607T115454Z-avarab@gmail.com>
Add a perf test for the refresh_index() function to compliment the
existing read()/discard() in a loop perf test added in
1ecb5ff141f (read-cache: add simple performance test, 2013-06-09).
Since this test is much slower (around 10x) than the previous
read()/discard() test let's run it 100 times instead of the 1000 time
the first one runs.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
t/helper/test-read-cache-perf.c | 12 ++++++++++++
t/perf/p0002-read-cache.sh | 5 +++++
2 files changed, 17 insertions(+)
diff --git a/t/helper/test-read-cache-perf.c b/t/helper/test-read-cache-perf.c
index 54ad0c3135..a2802559a5 100644
--- a/t/helper/test-read-cache-perf.c
+++ b/t/helper/test-read-cache-perf.c
@@ -11,8 +11,11 @@ int cmd__read_cache_perf(int argc, const char **argv)
{
struct repository *r = the_repository;
int cnt = -1;
+ int refresh = 0;
struct option options[] = {
OPT_INTEGER(0, "count", &cnt, "number of passes"),
+ OPT_BOOL(0, "refresh", &refresh,
+ "call refresh_index() in a loop, not read()/discard()"),
OPT_END()
};
@@ -26,10 +29,19 @@ int cmd__read_cache_perf(int argc, const char **argv)
options);
setup_git_directory();
+ if (refresh)
+ repo_read_index(r);
while (cnt--) {
+ if (refresh) {
+ unsigned int flags = REFRESH_QUIET|REFRESH_PROGRESS;
+ refresh_index(r->index, flags, NULL, NULL, NULL);
+ continue;
+ }
repo_read_index(r);
discard_index(r->index);
}
+ if (refresh)
+ discard_index(r->index);
return 0;
}
diff --git a/t/perf/p0002-read-cache.sh b/t/perf/p0002-read-cache.sh
index 1762b64865..cbccc5ace9 100755
--- a/t/perf/p0002-read-cache.sh
+++ b/t/perf/p0002-read-cache.sh
@@ -11,4 +11,9 @@ test_perf "read_cache/discard_cache $count times" "
test-tool read-cache-perf --count=$count
"
+count=100
+test_perf "refresh_index() $count times" "
+ test-tool read-cache-perf --count=$count --refresh
+"
+
test_done
--
2.32.0.rc3.434.gd8aed1f08a7
next prev parent reply other threads:[~2021-06-07 11:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 11:58 [PATCH 0/4] test-tool: split up "read-cache" tool Ævar Arnfjörð Bjarmason
2021-06-07 11:58 ` [PATCH 1/4] test-tool: split up test-tool read-cache Ævar Arnfjörð Bjarmason
2021-06-07 11:58 ` [PATCH 2/4] test-tools: migrate read-cache-perf to parse_options() Ævar Arnfjörð Bjarmason
2021-06-07 11:58 ` [PATCH 3/4] test-tools: migrate read-cache-again " Ævar Arnfjörð Bjarmason
2021-06-07 11:58 ` Ævar Arnfjörð Bjarmason [this message]
2021-06-07 22:50 ` [PATCH 0/4] test-tool: split up "read-cache" tool Junio C Hamano
2021-06-08 11:14 ` Ævar Arnfjörð Bjarmason
2021-06-08 23:26 ` Junio C Hamano
2021-06-30 22:02 ` Emily Shaffer
2021-06-30 22:24 ` Ævar Arnfjörð Bjarmason
2021-08-24 9:15 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
2021-08-24 9:15 ` [PATCH v2 1/4] test-tool: split up test-tool read-cache Ævar Arnfjörð Bjarmason
2021-08-24 9:15 ` [PATCH v2 2/4] test-tool: migrate read-cache-perf to parse_options() Ævar Arnfjörð Bjarmason
2021-08-24 9:15 ` [PATCH v2 3/4] test-tool: migrate read-cache-again " Ævar Arnfjörð Bjarmason
2021-08-24 9:15 ` [PATCH v2 4/4] read-cache perf: add a perf test for refresh_index() Ævar Arnfjörð Bjarmason
2021-08-24 22:19 ` [PATCH v2 0/4] test-tool: split up "read-cache" tool Taylor Blau
2021-08-25 0:18 ` Junio C Hamano
2021-08-27 7:24 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patch-4.4-120a37acae-20210607T115454Z-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).