From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B54471F727 for ; Tue, 7 Jun 2022 15:51:14 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qGdU17D3"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344317AbiFGPvO (ORCPT ); Tue, 7 Jun 2022 11:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236559AbiFGPvI (ORCPT ); Tue, 7 Jun 2022 11:51:08 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96F2EF33A9 for ; Tue, 7 Jun 2022 08:51:07 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id u8so20428364wrm.13 for ; Tue, 07 Jun 2022 08:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+4Ahy/6m/84ucWfcFHTC+Vfzg0oC8QUvy5LQLFp/Ous=; b=qGdU17D3WMdHkOc27fGB7COuaH8pCpk3iZJNTLy05DCwGLlmuOZnjrIRFK8ye/TmjN 8neO6noPnSBQHxC+4z2WnZneMcf3KG5mfbxZP05dRHuchnz6e3QkrjUucwClhn5oDp7u m/67GWynVKfR+qjCPK34SksNbI3yKO7TwuIpF0VlE+nHgl/ufzajxszDfCWFSr5lq52v E4r4ACA+9h54sLiovAvfuc1AeYc8jOf/3gb7fWxuGmCcrG1tM/xLYWtWqhuQCsnVWa5y L3DFIozZKp7d71HAqG+Ej64mKWO+lRF1wTIKHY9R0S4mTzMtAF6LvR4/l63rrAzD5YdM 4TKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+4Ahy/6m/84ucWfcFHTC+Vfzg0oC8QUvy5LQLFp/Ous=; b=0Gq2NNSTVwwfuSmucxXHYI1w0nB0e+yy2QjNQC1bief+e57mzn5CBNNpC5FmRFvaBy VFv0cZOVS3p/eI8IHBekEmC/v0M+toYTtsPbIjPYsY/obdJnwANZ254gkps7VZSHcQ5w CtRrQTv9OX+FG31qj+vODVL4PvTG5bZciPau11nXj/iWHD0bQxV/5KsUZ1r0iFMTDdBK Igih36kjPFATE1QXRjQ1cgulZsKTGkq4UbM8ZiXe0018fuBlTdwyUIh5VYj0oNXLn36s 7bXljaSERBuwrWHyX9YaIbqtbFH7+C8SHEIbAKvcJzn8yNR5v2zAZ5vhRCWE8dx9Ts05 dqkw== X-Gm-Message-State: AOAM532+qVUUUlNpFX0SvICfcACPLjh2lIU1ReBhGiYeqrSU0mWJMQUp iuXCGpC+GXOZX9KwDbjaJ+AouDqMmPQBJw== X-Google-Smtp-Source: ABdhPJx8TfbXWLGBw6aWVqPfet1RbECmySEPcPkUO4J2j3+VrYg/W7J/WAcva2Xl/bKRp0RV64+X5w== X-Received: by 2002:a5d:6d0d:0:b0:218:45b1:ef1f with SMTP id e13-20020a5d6d0d000000b0021845b1ef1fmr9359557wrq.558.1654617065869; Tue, 07 Jun 2022 08:51:05 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id s6-20020adfbc06000000b0020fe4c5e94csm18790056wrg.19.2022.06.07.08.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 08:51:05 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Glen Choo , Phillip Wood , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH 2/3] remote.c: don't dereference NULL in freeing loop Date: Tue, 7 Jun 2022 17:50:04 +0200 Message-Id: X-Mailer: git-send-email 2.36.1.1178.g0c3594a0ba5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Fix a bug in fd3cb0501e1 (remote: move static variables into per-repository struct, 2021-11-17) where we'd free(remote->pushurl[i]) after having NULL'd out remote->pushurl. itself. We free "remote->pushurl" in the next "for"-loop, so doing this appears to have been a copy/paste error. Before this change GCC 12's -fanalyzer would correctly note that we'd dereference NULL in this case, this change fixes that: remote.c: In function ‘remote_clear’: remote.c:153:17: error: dereference of NULL ‘*remote.pushurl’ [CWE-476] [-Werror=analyzer-null-dereference] 153 | free((char *)remote->pushurl[i]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [...] Signed-off-by: Ævar Arnfjörð Bjarmason --- remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/remote.c b/remote.c index 3e75db7bb4f..0b243b090d9 100644 --- a/remote.c +++ b/remote.c @@ -147,7 +147,7 @@ static void remote_clear(struct remote *remote) for (i = 0; i < remote->url_nr; i++) free((char *)remote->url[i]); - FREE_AND_NULL(remote->pushurl); + FREE_AND_NULL(remote->url); for (i = 0; i < remote->pushurl_nr; i++) free((char *)remote->pushurl[i]); -- 2.36.1.1178.g0c3594a0ba5