From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 6E7151F9F3 for ; Thu, 14 Oct 2021 00:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhJNAJW (ORCPT ); Wed, 13 Oct 2021 20:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbhJNAJE (ORCPT ); Wed, 13 Oct 2021 20:09:04 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911ACC061749 for ; Wed, 13 Oct 2021 17:06:49 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id k7so13665371wrd.13 for ; Wed, 13 Oct 2021 17:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s6j3yp6C58c0SnY0buPOfFanHYz9OMOAQb8QO7SzTYU=; b=nwF2MR9cBOOEYcVxnty1+yW7nqGzNRfD2MR/juCirr4MCPq8WFDglYkU5vDi+l4Bdj UPEwizM0tkCW9qUBpof4q/oINOzTC5AxPjwRHe9qLhEn9D+0vAE603vMY9iE/JPV0sqi VKVWEEgu8fUdHVSQXVHUZI4dvfSWL15CiGKsrIB9yd2tjWH7ZYmW76QqJMSa2z2Mhet6 EDkxIU4Ic0If11YbZ5MxVVjx/BRwhDDv5qmhyhrkf75jVwYaH/CU6sUDl7jJpB/KQfgc 9wz6XD6v/qEua8DEJQBBtwO8VCHqWuXS8pESrlc1qZ8MKJiyu8AtetGDAVyJIXWgAShN QOMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s6j3yp6C58c0SnY0buPOfFanHYz9OMOAQb8QO7SzTYU=; b=hpNfexX4CUhyWvVxOwRlBlgFGEo+kjSEQbkWYBUQ59OW5iClGv+QJmVdGhi3ykLpeB RpMf3l8eIXn2mM6APw7M8SkhJ05VvZvBdjoTwiTVMgPtBKzqM+HBZocgeiA62g5izm5A SIQ/v9npQQrv4/Klk9bxFfe+bthKWE0DPXtEXgkRPyWmYvJ2+owiQr8t25l7zDhXwcMe 5jqNuQoFD/VVQnOq96d4e+7zU69mEsmESC4I4ZRuhTbA0Bn2YhbmPo4tzRpDwhRXBP5O RsOpcxGHDhpoYUHSHsBz+VbZ1oJqFg6haoEGeZ3bLrfY0jfGTOhx6luUn2thDkjVAl4Q YtwA== X-Gm-Message-State: AOAM531UKpUCEDTdKsbu+Nc6Jk9zxMY65f2XFfJL9UxibHQQuiqHj/H4 uz+jly6tbVVWQf45Z/pHEEwTiLZcvzOUpw== X-Google-Smtp-Source: ABdhPJz4mV95lEf6p+C7tyZpOJMMlwA2yR9eDySgmTRKPZjRH0IBJlD8o9VjcajncFv92sTJq5Db7A== X-Received: by 2002:a05:600c:3b24:: with SMTP id m36mr2371071wms.176.1634170007957; Wed, 13 Oct 2021 17:06:47 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id y8sm670711wmi.43.2021.10.13.17.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 17:06:47 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Han-Wen Nienhuys , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH 18/20] refs API: don't expose "errno" in run_transaction_hook() Date: Thu, 14 Oct 2021 02:06:30 +0200 Message-Id: X-Mailer: git-send-email 2.33.1.1346.g48288c3c089 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org In run_transaction_hook() we've checked errno since 67541597670 (refs: implement reference transaction hook, 2020-06-19), let's reset errno afterwards to make sure nobody using refs.c directly or indirectly relies on it. Signed-off-by: Ævar Arnfjörð Bjarmason --- refs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/refs.c b/refs.c index 16f8220b108..9aa41b55c7b 100644 --- a/refs.c +++ b/refs.c @@ -2095,8 +2095,11 @@ static int run_transaction_hook(struct ref_transaction *transaction, update->refname); if (write_in_full(proc.in, buf.buf, buf.len) < 0) { - if (errno != EPIPE) + if (errno != EPIPE) { + /* Don't leak errno outside this API */ + errno = 0; ret = -1; + } break; } } -- 2.33.1.1346.g48288c3c089