From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E72581F670 for ; Thu, 14 Oct 2021 00:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbhJNAJF (ORCPT ); Wed, 13 Oct 2021 20:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbhJNAIx (ORCPT ); Wed, 13 Oct 2021 20:08:53 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CAB1C061775 for ; Wed, 13 Oct 2021 17:06:46 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id r18so13822935wrg.6 for ; Wed, 13 Oct 2021 17:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ivS5BuUXx6xI3vzfLGCUk6QPCf7Z5o0K9/GWjz7Pkuo=; b=cqklIL85clIFbVstdO+SGenSW5Vx8qXXk0ro6cIyyFluuCcxHzF2W+wg1ezLZoSL0T bAlh2oi/v2X1DxSkP9wIHwIPWrg7QawETCJkTWe+viqEkhQ2VyZ4+m/jZR+v0pf2RPjr ZRsDBysjEEVh3S8KisXtn1+6t3cyYn6ZBBwgcSvSMmqJZSHKpoyuXTdy/6UCrpiEEZPU HukOS6ZjIsYwOzesz0lz4z5E9fZnxgjzclL9JRmE1zi25RxmTgb3VBbYcbhLHPgayS7O LOy5/STXT31+nGyj0FFayF6AJg+RwyzAOLOJ6Soze7y1+wC9RlKa2aS480xPG9BSbk9Q f93w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ivS5BuUXx6xI3vzfLGCUk6QPCf7Z5o0K9/GWjz7Pkuo=; b=nnC93uNR5BCY8qBsRT0Nr6i1XhPQd6W/4b7Bqek3c+3f0Eq+18DV6FSlNoWjTBtjJY sWElzN/E8Opk8+mOhPMxWyRrEyZSOrZJQ2k/P2jYXsa70thGD3eofaaKqkl4RoTvbMU3 P7lRsSsGNhuvV6GhEtkf1gvfnnqE0Mkbww8wmVKDWCfRCoj1GYphOE6+KaaxZdt+zwSB qglvj9nPy2/B2CgXqNCtVvTs0eikP7PdafSJjr35OCYJy9qFGr8koxIjqK3rJse1uOnP gnti+RtODgkdfhcxnwWDufJFlaslFWnstlVbSB/cFEKIkmbOzdOvhHXROAobNwkmObFb LAfg== X-Gm-Message-State: AOAM531m6w58Tc7uaCU1mBcsbiCGFsiZPx7ixhe+nrsFD6cgFopAnF/q C9cClZjX2SscHmZ8Lu+BTaiLAS37m/yVCg== X-Google-Smtp-Source: ABdhPJytcaIe2wUdJm7qDQlUYmRhgcjnISUhGkO6gYQ16AeC4I4B1/zh2OJj1rS8wWjGyMilnp8yzg== X-Received: by 2002:a5d:47c3:: with SMTP id o3mr2740411wrc.25.1634170004998; Wed, 13 Oct 2021 17:06:44 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id y8sm670711wmi.43.2021.10.13.17.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 17:06:44 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Han-Wen Nienhuys , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH 14/20] refs API: make refs_resolve_refdup() not set errno Date: Thu, 14 Oct 2021 02:06:26 +0200 Message-Id: X-Mailer: git-send-email 2.33.1.1346.g48288c3c089 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Move refs_resolve_refdup() from the legacy refs_resolve_ref_unsafe() to the new refs_werrres_ref_unsafe(). I have read its callers and determined that they don't care about errno being set. Signed-off-by: Ævar Arnfjörð Bjarmason --- refs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/refs.c b/refs.c index 001f54845a7..c64ed6285a6 100644 --- a/refs.c +++ b/refs.c @@ -267,9 +267,10 @@ char *refs_resolve_refdup(struct ref_store *refs, struct object_id *oid, int *flags) { const char *result; + int ignore_errno; - result = refs_resolve_ref_unsafe(refs, refname, resolve_flags, - oid, flags); + result = refs_werrres_ref_unsafe(refs, refname, resolve_flags, + oid, flags, &ignore_errno); return xstrdup_or_null(result); } -- 2.33.1.1346.g48288c3c089