From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9D61C1F934 for ; Mon, 12 Apr 2021 11:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240126AbhDLLJ5 (ORCPT ); Mon, 12 Apr 2021 07:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240052AbhDLLJk (ORCPT ); Mon, 12 Apr 2021 07:09:40 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFD7FC06138F for ; Mon, 12 Apr 2021 04:09:22 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id w186so2029462wmg.3 for ; Mon, 12 Apr 2021 04:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=swSie5ck3VhtKLBfrJHlPXMiVBO9s/osIov1znO1B6g=; b=d+QGOkxgSimREhMqVkaweQ1YUodHHlWKIAIR61lMOFfX8mfmwBBCCydHnItLGP8dzS uhcNTvP+JS4qBVWUanMMrDk9kIkjNBQEFpE45447vU1bx08cLzgEQbJC35G954z7B56O pDQcPsIPLSm1DVGl8S0e0u3//8FPIbCu4/P0zv9i++U4MFWYbRgZ4P59SIeuT3N/s4UL v7pOnkuAOB3K8907LN3azn1W306TXhTyiEJ3S5PY+aPd+d+yPiJCtt2oBrGdyOVmZoZr QrWLiqc5Abc0A8b6j690rqbqTq0sBCpZDE1/4GXlU5lp3JiFQ/IY4T8f0SHOV+uPAb/j r1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=swSie5ck3VhtKLBfrJHlPXMiVBO9s/osIov1znO1B6g=; b=V2SaKxwD6XsZNKjbieERog7ugRnRTRBp++jmKE4WfeyObhcc2Cnh0SzQcvSUFZKgJN yXuJZhU/i2BiWCCKZAFiWXQbzqBSL/WPksA+6G2AkGeQjEoUZtfUZ7Tz090sgUNqkPKO /vZmHpBwGRYACtBNV0U039iBix+3iZc6Q+/ppMN16EzSFfMSIPqqWxpNDXJ8vyln2G5u BbBhZsTlCE3AqLTZ/fkn3JchEpzayspLda4N5evbePZ0iCOQH3i4xm5nqZAi7VmLPCox sEoA5kTGzIV52LFpZK7jQNAxZ9v/3bnrgRMVsIp1D3h+cXrPHmDk6VNqAQLhraq7EtXx Y99Q== X-Gm-Message-State: AOAM533qVFUZ4dFVcUYCzKmLUJEKpi4lLdYE3Rg9uDLgup+L5Jf1+QdA bRtYjqrpQKxU9Mwsg5+sMtuHyl2pi5BgIA== X-Google-Smtp-Source: ABdhPJy/HrceZWuNvZ0ZiKD2Y57uQPcbikCw6TyhEovIGYvV/0P7+snUh6aB/M4jt4VHhU9FA2f7zA== X-Received: by 2002:a1c:2587:: with SMTP id l129mr25944124wml.135.1618225761429; Mon, 12 Apr 2021 04:09:21 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id a8sm18158744wrh.91.2021.04.12.04.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 04:09:20 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Matthieu Moy , Johannes Schindelin , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH 14/16] test-lib-functions: use "return 1" instead of "false" Date: Mon, 12 Apr 2021 13:09:03 +0200 Message-Id: X-Mailer: git-send-email 2.31.1.634.gb41287a30b0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change a few functions that relied on a "false" being the last statement in the function to use an explicit "return 1" like the other functions in this file. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/test-lib-functions.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 2518a9b8274..c46bf0ff09c 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -763,7 +763,7 @@ test_path_is_file () { if ! test -f "$1" then echo "File $1 doesn't exist" - false + return 1 fi } @@ -772,7 +772,7 @@ test_path_is_dir () { if ! test -d "$1" then echo "Directory $1 doesn't exist" - false + return 1 fi } @@ -781,7 +781,7 @@ test_path_exists () { if ! test -e "$1" then echo "Path $1 doesn't exist" - false + return 1 fi } @@ -803,7 +803,7 @@ test_file_not_empty () { if ! test -s "$1" then echo "'$1' is not a non-empty file." - false + return 1 fi } -- 2.31.1.634.gb41287a30b0